Adds CLI install instructions #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achamayou
reviewed
Oct 23, 2024
|
The create_changelog failure seems to be caused by the workflow's logic expecting the change to come from a branch and not a fork. There is an allusion to what may be a related issue in https://github.com/microsoft/CoseSignTool/blob/main/docs/CONTRIBUTING.md#pull-request-process, it's something that needs fixing to enable contributions from outside the immediate team. |
achamayou
approved these changes
Oct 23, 2024
elantiguamsft
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The immediate issue is that the "tool" is confusing as it does not state if the releases are only for .NET or if they contain the CLI binaries. The next problem is that the zipped files contain a bunch of DLLs and it is not obvious where the executable is, especially on Linux and MacOS where such behavior is unexpected and usually there is just one binary.
To disambiguate I've added download instructions to the main readme to make it immediately obvious how to download and use it.