New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for protected and unprotected headers #100

Merged

msftsettiy merged 15 commits into main from msftsettiy/headers-support

Aug 19, 2024

Collaborator

msftsettiy commented Aug 15, 2024

This PR contains code and tests to allow users to supply protected and un-protected headers in the tool. Two options are provided for specifying headers. They are as follows:

A JSON file containing the collection of headers.
Command-line flags to specify a collection of name-value pairs that represent the headers.

In this iteration, headers containing either an int32 value or a string value are supported.

Help text for the sign command and CoseSignTool.md are updated.

settiy-ms added 6 commits

August 14, 2024 14:53


          Added support for integer and string headers

bc0f2ee


          Added command line option to provide headers

4c1996b


          Update documentation on cosesigntool.md

a4b517b


          Remove unused packages

d8073b2


          Bug fix

156dd2e


          Fixed the help text for sign command

5bd2e52

github-actions bot assigned msftsettiy

lemccomb reviewed

View reviewed changes

CoseHandler/CoseHandler.cs Show resolved Hide resolved

lemccomb reviewed

View reviewed changes

CoseHandler/CoseHandler.cs Show resolved Hide resolved

lemccomb reviewed

View reviewed changes

CoseHandler/CoseHandler.cs Show resolved Hide resolved

lemccomb reviewed

View reviewed changes

CoseSign1.Tests.Common/FileSystemUtils.cs Show resolved Hide resolved

lemccomb reviewed

View reviewed changes

CoseSignTool.Tests/CoseSignTool.Tests.csproj Outdated Show resolved Hide resolved

lemccomb reviewed

View reviewed changes

CoseSignTool.Tests/MainTests.cs Outdated Show resolved Hide resolved

lemccomb reviewed

View reviewed changes

CoseSignTool.Tests/MainTests.cs Show resolved Hide resolved

lemccomb reviewed

View reviewed changes

CoseSignTool.Tests/Properties/launchSettings.json Outdated Show resolved Hide resolved

lemccomb reviewed

View reviewed changes

CoseSignTool/CoseSignTool.csproj Outdated Show resolved Hide resolved

lemccomb reviewed

View reviewed changes

CoseSignTool/Local/HeaderStringConverter.cs Show resolved Hide resolved

lemccomb reviewed

View reviewed changes

CoseSignTool/SignCommand.cs Show resolved Hide resolved

lemccomb reviewed

View reviewed changes

docs/CoseSignTool.md Outdated Show resolved Hide resolved

lemccomb reviewed

View reviewed changes

Contributor

lemccomb left a comment

Looks good overall.
I have a couple suggested tweaks.

settiy-ms added 2 commits

August 15, 2024 21:52


          Fixed review comments

9ee7a8b


          Delete unused tests

e9a33fc

lemccomb reviewed

View reviewed changes

CoseSignTool/CoseCommand.cs Outdated Show resolved Hide resolved

settiy-ms and others added 3 commits

August 16, 2024 17:04


          Added header extender provider to all the sign overload methods in co…

f1917f1

…se handler project


          Removed unused properties directory

acb23a1


          Merge branch 'main' into msftsettiy/headers-support

061bf35

Signed-off-by: msftsettiy <63882775+msftsettiy@users.noreply.github.com>

github-advanced-security bot found potential problems

View reviewed changes

CoseSign1.Headers.Tests/CoseHeaderFactoryTests.cs Fixed Show fixed Hide fixed

CoseSign1.Headers.Tests/CoseHeaderFactoryTests.cs Fixed Show resolved Hide resolved

CoseSign1.Headers/CoseHeaderFactory.cs Fixed Show resolved Hide resolved

CoseSign1.Headers/CoseHeaderFactory.cs Fixed Show resolved Hide resolved

CoseSignTool.Tests/MainTests.cs Fixed Show resolved Hide resolved

actions-user and others added 3 commits

August 17, 2024 00:16


          Update changelog for release

73c98d9


          Fixed cose header tests to ensure that the factory instance is dispos…

4e36758

…ed during exceptions


          Merge branch 'msftsettiy/headers-support' of https://github.com/micro…

abd9df5

…soft/CoseSignTool into msftsettiy/headers-support

Merging changes from main to user branch


          Fixed tests

008d7cf

lemccomb approved these changes

View reviewed changes

Contributor

lemccomb left a comment

Looks good.

msftsettiy merged commit 9c6de13 into main

10 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet