Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emulator Launch, Commands and Extension Tech Debt Buydown #1577

Merged
merged 22 commits into from
May 23, 2019

Conversation

justinwilaby
Copy link
Contributor

@justinwilaby justinwilaby commented May 15, 2019

This WIP addresses provides some much needed buydown of tech debt regarding how the Emulator is launched, the extensions infrastructure and the command system.

This PR provides:

  1. Decorators for registering a command and a DI container for the command service. e.g.
class MyClass {
 @CommandServiceInstance()
 private commandService: CommandServiceImpl;

 @Command('commandName')
 protected myCommand(args) {
    // Do stuff
  }
}
  1. Removal of the ts-loader from webpack which halves the build times
  2. Targeting ES6+ in the build and using terser for minification
  3. Bumped botframework-config out of preview and into v4.4

fixes #1588

@justinwilaby justinwilaby marked this pull request as ready for review May 21, 2019 20:29
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like tests for the CommandService, CommandRegistry, and Extensions changes

@cwhitten
Copy link
Member

@justinwilaby have we gone through the 4.5 release checklist on this change?

@tonyanziano
Copy link
Contributor

:shipit: :shipit: :shipit: :shipit: :shipit: :shipit:

@justinwilaby justinwilaby merged commit a1fa135 into master May 23, 2019
@justinwilaby justinwilaby deleted the jwilaby/tech-debt branch May 23, 2019 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conversation UI fails to load at first launch
3 participants