Bumps botframework-config in the main package to 4.4.0 (#1521)

microsoft · May 6, 2019 · 972a4e7 · 972a4e7
1 parent add1f1c
commit 972a4e7
Show file tree

Hide file tree

Showing 4 changed files with 101 additions and 7 deletions.
diff --git a/packages/app/main/package-lock.json b/packages/app/main/package-lock.json
diff --git a/packages/app/main/package.json b/packages/app/main/package.json
@@ -132,7 +132,7 @@
     "@bfemulator/sdk-shared": "^1.0.0",
     "applicationinsights": "^1.0.8",
     "base64url": "2.0.0",
-    "botframework-config": "4.0.0-preview1.3.4",
+    "botframework-config": "4.4.0",
     "botframework-schema": "^4.3.4",
     "chatdown": "^1.0.10",
     "chokidar": "^2.0.2",

diff --git a/packages/app/main/src/services/luisApiService.ts b/packages/app/main/src/services/luisApiService.ts
@@ -91,6 +91,7 @@ export class LuisApi {
           type: luisModel.activeVersion === 'Dispatch' ? ServiceTypes.Dispatch : ServiceTypes.Luis,
           version: luisModel.activeVersion,
           region: luisModel.region,
+          getEndpoint: () => luisModel.region,
         };
       }
     ) as ILuisService[];

diff --git a/packages/app/main/src/services/qnaApiService.spec.ts b/packages/app/main/src/services/qnaApiService.spec.ts
@@ -284,7 +284,7 @@ describe('The QnaApiService happy path', () => {
     expect(result.services).toEqual([
       {
         endpointKey: 'primary-endpoint-key-1',
-        hostname: 'https://localhost',
+        hostname: 'https://localhost/qnamaker',
         id: '1234',
         kbId: '1234',
         name: 'HIThere#1',
@@ -293,7 +293,7 @@ describe('The QnaApiService happy path', () => {
       },
       {
         endpointKey: 'primary-endpoint-key-2',
-        hostname: 'https://localhost',
+        hostname: 'https://localhost/qnamaker',
         id: '9876543',
         kbId: '9876543',
         name: 'HIThere#2',