-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: switching in project tree is lagging #5524
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhixzhan
reviewed
Jan 14, 2021
zhixzhan
reviewed
Jan 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, split design page breadcrumb to a self render components really improve a lot.
boydc2014
approved these changes
Jan 14, 2021
lei9444
added a commit
that referenced
this pull request
Jan 14, 2021
* fix: project tree switch item lagging * fix tests Co-authored-by: Dong Lei <donglei@microsoft.com>
benbrown
pushed a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
* fix: project tree switch item lagging * fix tests Co-authored-by: Dong Lei <donglei@microsoft.com>
benbrown
pushed a commit
that referenced
this pull request
Jun 11, 2021
* fix: project tree switch item lagging * fix tests Co-authored-by: Dong Lei <donglei@microsoft.com>
lei9444
added a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* fix: project tree switch item lagging * fix tests Co-authored-by: Dong Lei <donglei@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switching in project tree is causing too much re-rendering (including some full re-rendering), up to 8 times in a simple switch. This fix some simple refactoring that saves us at least 4 full rendering times, leaves us to 3-4 partial rendering. Will continue investigate the other unnecessary rendering.
The goal eventually is to have only one rendering in one switch.
Root cause
Fix
next step
Task Item
#minor
Screenshots
before
after