Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: l18n apostrophe errors #5515

Merged
merged 4 commits into from
Jan 13, 2021
Merged

fix: l18n apostrophe errors #5515

merged 4 commits into from
Jan 13, 2021

Conversation

beyackle
Copy link
Contributor

Description

Some of our locale files had quote marks in places that broke ICU formatting. This should fix those.

Task Item

fixes #5496

tonyanziano
tonyanziano previously approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What generates these translations? If it's a script, can we modify the script to avoid inserting these double quotes so that we can prevent breaks like this from happening again?

@coveralls
Copy link

coveralls commented Jan 13, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 54.897% when pulling 4cb5e23 on beyackle/l18n_quoteFix into 094818a on main.

@beyackle
Copy link
Contributor Author

@tonyanziano
They're generated by human translators. While we can't directly script them, we can at least write a script to double-check their work and catch mistakes like this before they go into the product,

@cwhitten cwhitten merged commit 8923e14 into main Jan 13, 2021
@cwhitten cwhitten deleted the beyackle/l18n_quoteFix branch January 13, 2021 23:40
lei9444 pushed a commit that referenced this pull request Jan 14, 2021
@beyackle @lei9444
fix: l18n apostrophe errors (#5515)
0aaaacf 
* fix some l18n apostrophe errors

* Curlify quotes

* fix issues in l18n files
benbrown pushed a commit to benbrown/BotFramework-Composer that referenced this pull request May 24, 2021
@beyackle @lei9444
fix: l18n apostrophe errors (microsoft#5515)
e2c8ad9 
* fix some l18n apostrophe errors

* Curlify quotes

* fix issues in l18n files
benbrown pushed a commit that referenced this pull request Jun 11, 2021
@beyackle @lei9444
fix: l18n apostrophe errors (#5515)
533980d 
* fix some l18n apostrophe errors

* Curlify quotes

* fix issues in l18n files
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@beyackle
fix: l18n apostrophe errors (microsoft#5515)
e5083a7 
* fix some l18n apostrophe errors

* Curlify quotes

* fix issues in l18n files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyanziano tonyanziano tonyanziano approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@cwhitten cwhitten Awaiting requested review from cwhitten

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@hatpick hatpick Awaiting requested review from hatpick

@srinaath srinaath Awaiting requested review from srinaath

Assignees

@tonyanziano tonyanziano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MCS-DE] Electron App freezes when opening a bot
4 participants
@beyackle @coveralls @tonyanziano @cwhitten