Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update Orchestrator requirement docs in prep for Composer 1.3.1 #5481

Merged
merged 22 commits into from
Jan 13, 2021

Conversation

taicchoumsft
Copy link
Member

Description

Add documentation for Orchestrator preview. Also make clear that it's possible to publish bot again in 32-bit, even though Composer itself has to run in 64-bit.

Task Item

#minor

@coveralls
Copy link

coveralls commented Jan 10, 2021

Coverage Status

Coverage increased (+0.01%) to 54.876% when pulling 38ca550 on tachou/orchestratorDocs into 121d4c2 on main.

tsuwandy
tsuwandy previously approved these changes Jan 11, 2021
@zxyanliu
Copy link
Contributor

zxyanliu commented Jan 11, 2021

@taicchoumsft thanks for providing the content.
I did a language and formatting pass and provided some minor suggestions.

Here are a few additional comments:

  • Do you plan to add a Learn more link of Orchestrator in Composer UI and point users to the orchestrator.md file? If so, you will need an aka link for this doc.
  • Can you change all headings to sentence case instead of title case?

zxyanliu
zxyanliu previously approved these changes Jan 11, 2021
@taicchoumsft taicchoumsft dismissed stale reviews from zxyanliu and tsuwandy via e490854 January 11, 2021 18:33
@taicchoumsft
Copy link
Member Author

taicchoumsft commented Jan 11, 2021

@taicchoumsft thanks for providing the content.
I did a language and formatting pass and provided some minor suggestions.

Here are a few additional comments:

  • Do you plan to add a Learn more link of Orchestrator in Composer UI and point users to the orchestrator.md file? If so, you will need an aka link for this doc.
  • Can you change all headings to sentence case instead of title case?

Yes, we currently have a aka link pointing to another Orchestrator doc (aka.ms/bf-orchestrator), I'll sync with our PM to make the change if necessary.

Made sentence case change. Thanks @zxyanliu for your input here.

scheyal
scheyal previously approved these changes Jan 11, 2021
Copy link
Contributor

@scheyal scheyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. thank you.

@boydc2014 boydc2014 merged commit 55c9054 into main Jan 13, 2021
@boydc2014 boydc2014 deleted the tachou/orchestratorDocs branch January 13, 2021 05:51
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
…microsoft#5481)

* Remove Orchestrator from runtime

* remove pdb hack as well

* Start of Orchestrator docs

* Adding Orch to runtime

* v1 of doc

* Notes to publish to 32-bit

* Use Yan's images (grey border)

* Address Tien, Yan's comments

* Sentencecase changes

* Remove uneeded line

* typos

* Minor corrections and typo fixes.

* minor image formatting

* more minor typo fixes

* Minor formatting for images

* bullet point fix

Co-authored-by: Dong Lei <donglei@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants