chore: Avoid re-render from states value change #5466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, can you list how much time is saved? |
srinaath
reviewed
Jan 8, 2021
Composer/packages/client/src/pages/language-generation/LGPage.tsx
Outdated
Show resolved
Hide resolved
Number of render times has been reduced from 2 to 1, it should save 50% render UI time. |
boydc2014
approved these changes
Jan 11, 2021
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* consume less state to avoid re-render * avoid submit no change * consume less states in project router * types clean up * update * lint Co-authored-by: Dong Lei <donglei@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some components consume too much unnecessary states which can cause itself re-render. By reducing them can avoid re-render.
Task Item
refs #5396
Screenshots
Inline editing on LG all up view table-list:
Before (several re-render):
After (one render):
