Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: project tree show incorrect imports #5361

Merged
merged 14 commits into from
Jan 8, 2021
Merged

fix: project tree show incorrect imports #5361

merged 14 commits into from
Jan 8, 2021

Conversation

zhixzhan
Copy link
Contributor

@zhixzhan zhixzhan commented Dec 17, 2020 •
edited
Loading

Description

Previous imports info is get from content by RegExp match, that is not accurate when LG body include markdown style text.

Fix it by get imports from LG parser side, same to LU/QnA.

Task Item

close #5347

Screenshots

image

@zhixzhan zhixzhan force-pushed the zhixzhan/imports-in-projecttree branch from 32d8a4e to 1565649 Compare December 17, 2020 07:49
@coveralls
Copy link

coveralls commented Dec 17, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 54.801% when pulling 4bbfb1b on zhixzhan/imports-in-projecttree into bb3a8ef on main.

beyackle
beyackle previously requested changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@beyackle beyackle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it should work, but I think the type structure needs more clarity.

hatpick
hatpick previously approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@hatpick hatpick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you.

@zhixzhan zhixzhan requested a review from beyackle December 18, 2020 06:32
hatpick
hatpick previously approved these changes Dec 18, 2020
View reviewed changes
@zhixzhan zhixzhan merged commit ad6ee2c into main Jan 8, 2021
@zhixzhan zhixzhan deleted the zhixzhan/imports-in-projecttree branch January 8, 2021 07:44
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@zhixzhan @hatpick @boydc2014
fix: project tree show incorrect imports (microsoft#5361)
1fbd27b 
* get imports from parser

* clean up

* define type for lu sections

* merge conflict

* clean up

Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: Dong Lei <donglei@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hatpick hatpick hatpick approved these changes

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@cwhitten cwhitten Awaiting requested review from cwhitten

@srinaath srinaath Awaiting requested review from srinaath

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

@beyackle beyackle Awaiting requested review from beyackle

Assignees

@hatpick hatpick

@beyackle beyackle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LG navigation pane shows all markdown links as imported LG files
5 participants
@zhixzhan @coveralls @hatpick @beyackle @boydc2014