Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: Remove Orchestrator pdbs from Azure publish flow #5282

Merged
merged 2 commits into from
Dec 10, 2020
Merged

revert: Remove Orchestrator pdbs from Azure publish flow #5282

merged 2 commits into from
Dec 10, 2020

Conversation

taicchoumsft
Copy link
Member

This reverts commit 0f4820f.

Description

Breaks publishing flow with an error:

Error: An assembly specified in the application dependencies manifest (Microsoft.BotFramework.Composer.WebApp.deps.json) was not found: package: 'Microsoft.BotFramework.Orchestrator', version: '4.11.0-daily.20201023.178190' path: 'runtimes/win-x64/native/oc_abi.pdb'

More investigation needed.

Task Item

#minor

@taicchoumsft taicchoumsft self-assigned this Dec 10, 2020
@taicchoumsft taicchoumsft changed the title Revert "Remove Orchestrator pdbs from Azure publish flow (#5275)" revert: Remove Orchestrator pdbs from Azure publish flow Dec 10, 2020
@coveralls
Copy link

coveralls commented Dec 10, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 55.305% when pulling 159af92 on tachou/revertPdbChange into 824f3e4 on main.

@cwhitten cwhitten merged commit 73f048f into main Dec 10, 2020
@cwhitten cwhitten deleted the tachou/revertPdbChange branch December 10, 2020 20:21
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@taicchoumsft @benbrown
Revert "Remove Orchestrator pdbs from Azure publish flow (microsoft#5275
5549fd1 
)" (microsoft#5282)

This reverts commit f94c72c.

Co-authored-by: Ben Brown <benbro@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbrown benbrown benbrown approved these changes

@cwhitten cwhitten cwhitten approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@luhan2017 luhan2017 Awaiting requested review from luhan2017

Assignees

@benbrown benbrown

@cwhitten cwhitten

@taicchoumsft taicchoumsft

Labels
1.3 1.3 Release Area: Orchestrator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@taicchoumsft @coveralls @benbrown @cwhitten