Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Qna pairs are being duplicated in the Qna knowledge base #5253

Merged
merged 2 commits into from
Dec 9, 2020

Conversation

lei9444
Copy link
Contributor

@lei9444 lei9444 commented Dec 9, 2020

Description

Root cause

we have source qna file and dialog qna file today. The dialog qna file will import the the source qna file. When we do a qna publish, the loader will add source file content to the qna content of the dialog, then publish all these two files to the Qna maker.

fix
do a filter to prevent publish source file to the service.

Task Item

closes #5104

Screenshots

image

@coveralls
Copy link

coveralls commented Dec 9, 2020

Coverage Status

Coverage decreased (-0.01%) to 55.367% when pulling 570af5c on lei9444:qnafilter into 4faf250 on microsoft:main.

@boydc2014 boydc2014 merged commit 9d42269 into microsoft:main Dec 9, 2020
@lei9444 lei9444 deleted the qnafilter branch February 1, 2021 02:06
lei9444 added a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QnA pairs are being duplicated in the QnA knowledge base
4 participants