Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: azure publish failed #5098

Merged
merged 5 commits into from
Dec 4, 2020
Merged

fix: azure publish failed #5098

merged 5 commits into from
Dec 4, 2020

Conversation

lei9444
Copy link
Contributor

@lei9444 lei9444 commented Dec 4, 2020

Description

issue 1
when the bot doesn't need to publish the luis files and the luis settings may be empty, we don't need to do luis publish. But in our azure publish flow today, we still publish luis to the prediction endpoint, and will throw error when the setting is empty.

fix
Don't do luis publish when we have no luis build.

issue 2
during the azure publish state, we use bf-lu to build the luis file. and bf-lu will create a setting file after the build finish. The file name format is luis.settings.{environment}.{region}.json. If user remove the environment from the settings, the name will become luis.settings..{region}.json. But the runtime has a default value when the environment is empty. So the runtime can't load the setting file when the environment is empty.

fix
add default value when the environment is empty.

Some other update
There is a logger will use the response to print from the publish request. But the response is not match the logger parameter in the azure publish flow. It will throw error when the flow run to this line. So in this PR I remove it first and we can take some time to investigate the response and make it available here.

In the feature, I think we should check the publish config before publishing. This may reduce some strange issues.

Task Item

#minor
closes #5108

Screenshots

@coveralls
Copy link

coveralls commented Dec 4, 2020

Coverage Status

Coverage remained the same at 55.671% when pulling 564ef84 on lei9444:azurep into 2a5d599 on microsoft:main.

@cwhitten cwhitten merged commit 98eb0f2 into microsoft:main Dec 4, 2020
@lei9444 lei9444 deleted the azurep branch February 1, 2021 02:06
lei9444 added a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* fix: azure publish failed

* remove responce

Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com>
Co-authored-by: Dong Lei <donglei@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure publish fail
5 participants