Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: QnA and project tree UX from botprojects #5070

Merged
merged 13 commits into from
Dec 4, 2020
Merged

fix: QnA and project tree UX from botprojects #5070

merged 13 commits into from
Dec 4, 2020

Conversation

zhixzhan
Copy link
Contributor

@zhixzhan zhixzhan commented Dec 3, 2020 •
edited
Loading

Description

Fix some inconsistencies UX from botprojects branch.

  1. Create qna on skill bot from project tree, View KB should navigate to skill bot url
  2. Click Back from QnA scratch modal, should show from url modal, not dismiss all.
  3. In LG/LU page project tree, should not show Add new knowledge base menu.

image

  1. Enable create manifest for root bot

image

  1. Fix project tree default selected item in LG/LU/QnA page.

  2. Do not warn Missing skill manifest for root bot

Task Item

#minor
close #5082
close #5083

Screenshots

@coveralls
Copy link

coveralls commented Dec 3, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 55.754% when pulling f9bdf35 on zhixzhan/botprojects-fix into d15d465 on main.

@boydc2014 boydc2014 added the 1.3 1.3 Release label Dec 3, 2020
@lei9444
Copy link
Contributor

lei9444 commented Dec 3, 2020

I have tested the PR and found a issue:
When I create a new KB from the menu context for the inactive project in the project tree, then click the view KB, The URL changed but the focus item in project tree didn't change.
test

@zhixzhan
Copy link
Contributor Author

zhixzhan commented Dec 4, 2020

I have tested the PR and found a issue:
When I create a new KB from the menu context for the inactive project in the project tree, then click the view KB, The URL changed but the focus item in project tree didn't change.
test

@lei9444 Nice catch, actually / did not take default selected item from LG/LU/QnA page.
Fixed now.

@lei9444 lei9444 merged commit 7eb138a into main Dec 4, 2020
@lei9444 lei9444 deleted the zhixzhan/botprojects-fix branch December 4, 2020 08:38
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@zhixzhan @boydc2014
fix: QnA and project tree UX from botprojects (microsoft#5070)
cf3d3c6 
* do not show `Add new knowledge base` in LG/LU page

* fix Back from QnA scratch modal

* `View KB` navigate to right url

* lint

* Enable create manifest for root bot

* fix LG/LU/QnA page project tree default selected item

* do not warning `Missing skill manifest` for root bot

* lint fix

Co-authored-by: Dong Lei <donglei@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boydc2014 boydc2014 boydc2014 approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@beyackle beyackle Awaiting requested review from beyackle

@cwhitten cwhitten Awaiting requested review from cwhitten

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@hatpick hatpick Awaiting requested review from hatpick

@srinaath srinaath Awaiting requested review from srinaath

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
1.3 1.3 Release
Projects
None yet
Milestone
No milestone
4 participants
@zhixzhan @coveralls @lei9444 @boydc2014