fix: Start bots panel design and error popup issues #5061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 2, 2020 00:34
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Hold the failed status Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Adjusted polling interval Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Updated regex Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Error callout visibility Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Adjust styles Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Added a stopping status Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Tests wrapped up Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
…otFramework-Composer into srravich/bugfix-dotnet-error
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Style updates Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Global controller visibility set Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
…oser into srravich/bugfix-dotnet-error Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> # Conflicts: # Composer/packages/server/src/locales/en-US.json # extensions/vacore/yarn.lock
…otFramework-Composer into srravich/bugfix-dotnet-error
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
added 3 commits
December 2, 2020 13:54
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
beyackle
approved these changes
Dec 2, 2020
| }; | ||
|
|
||
| const checkIfDotnetVersionMissing = (err: any) => { | ||
| return /(Command failed: dotnet build)| (Command failed: dotnet user-secrets)|(install[\w\r\s\S\t\n]*\.NET Core SDK)/.test( |
There was a problem hiding this comment.
I'm not sure I understand that character class. \s\S together means "any character at all", so just install.*\.NET should work fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Misc fixes for start bots panel styles.
Screenshots
Fixes #4975