Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updated installOneAuth script to target correct version. #5020

Merged
merged 4 commits into from
Dec 1, 2020

Conversation

tonyanziano
Copy link
Contributor

Description

Previous runs of the Windows build process were installing version 0.15.0 instead of the desired 1.14.0.

This updates the installation script to target a specific version. (Mac should be unaffected)

Proof of the older version being installed on a recent run of the build pipeline:

image

#minor

@tonyanziano tonyanziano changed the title Updated installOneAuth script to target correct version. chore: Updated installOneAuth script to target correct version. Nov 30, 2020
@coveralls
Copy link

coveralls commented Nov 30, 2020

Coverage Status

Coverage remained the same at 55.385% when pulling cd52d43 on toanzian/oneauth-version into 20e1d91 on main.

@tonyanziano tonyanziano merged commit e63a30c into main Dec 1, 2020
@tonyanziano tonyanziano deleted the toanzian/oneauth-version branch December 1, 2020 21:47
boydc2014 pushed a commit that referenced this pull request Dec 2, 2020
* try-catch around trigger grouping expressions (#5017)

Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>

* chore: Updated installOneAuth script to target correct version. (#5020)

* Updated installOneAuth script to target correct version.

* Better refactor

* feat: adaptive expression functions menu (#5015)

* expressions menu

* Fixing aligment of menu

* PR comments

Co-authored-by: Soroush <hatpick@gmail.com>

* fix: Correct handling of focus for Intellisense fields (#5039)

* fix

* Improved handling of focus when leveraging an Intellisense suggestion

* comments on wrong lines

* feat: azure publish with orchestrator (#5011)

* refactor the luis build in azure publish

* update the orchestrator path

* update the cleanup

* fix typo

* catch the build error

* remove qna endpoint

* remove console

* add qnaconfig

Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com>
Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
Co-authored-by: Tony Anziano <tonyanziano5@gmail.com>
Co-authored-by: LouisEugeneMSFT <66701106+LouisEugeneMSFT@users.noreply.github.com>
Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: leileizhang <leilzh@microsoft.com>
boydc2014 pushed a commit that referenced this pull request Dec 2, 2020
* try-catch around trigger grouping expressions (#5017)

Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>

* chore: Updated installOneAuth script to target correct version. (#5020)

* Updated installOneAuth script to target correct version.

* Better refactor

* feat: adaptive expression functions menu (#5015)

* expressions menu

* Fixing aligment of menu

* PR comments

Co-authored-by: Soroush <hatpick@gmail.com>

* fix: Correct handling of focus for Intellisense fields (#5039)

* fix

* Improved handling of focus when leveraging an Intellisense suggestion

* comments on wrong lines

* feat: azure publish with orchestrator (#5011)

* refactor the luis build in azure publish

* update the orchestrator path

* update the cleanup

* fix typo

* catch the build error

* remove qna endpoint

* remove console

* add qnaconfig

Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com>
Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
Co-authored-by: Tony Anziano <tonyanziano5@gmail.com>
Co-authored-by: LouisEugeneMSFT <66701106+LouisEugeneMSFT@users.noreply.github.com>
Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: leileizhang <leilzh@microsoft.com>
boydc2014 pushed a commit that referenced this pull request Dec 2, 2020
* try-catch around trigger grouping expressions (#5017)

Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>

* chore: Updated installOneAuth script to target correct version. (#5020)

* Updated installOneAuth script to target correct version.

* Better refactor

* feat: adaptive expression functions menu (#5015)

* expressions menu

* Fixing aligment of menu

* PR comments

Co-authored-by: Soroush <hatpick@gmail.com>

* fix: Correct handling of focus for Intellisense fields (#5039)

* fix

* Improved handling of focus when leveraging an Intellisense suggestion

* comments on wrong lines

* feat: azure publish with orchestrator (#5011)

* refactor the luis build in azure publish

* update the orchestrator path

* update the cleanup

* fix typo

* catch the build error

* remove qna endpoint

* remove console

* add qnaconfig

Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com>
Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
Co-authored-by: Tony Anziano <tonyanziano5@gmail.com>
Co-authored-by: LouisEugeneMSFT <66701106+LouisEugeneMSFT@users.noreply.github.com>
Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: leileizhang <leilzh@microsoft.com>
benbrown pushed a commit to benbrown/BotFramework-Composer that referenced this pull request May 24, 2021
* try-catch around trigger grouping expressions (microsoft#5017)

Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>

* chore: Updated installOneAuth script to target correct version. (microsoft#5020)

* Updated installOneAuth script to target correct version.

* Better refactor

* feat: adaptive expression functions menu (microsoft#5015)

* expressions menu

* Fixing aligment of menu

* PR comments

Co-authored-by: Soroush <hatpick@gmail.com>

* fix: Correct handling of focus for Intellisense fields (microsoft#5039)

* fix

* Improved handling of focus when leveraging an Intellisense suggestion

* comments on wrong lines

* feat: azure publish with orchestrator (microsoft#5011)

* refactor the luis build in azure publish

* update the orchestrator path

* update the cleanup

* fix typo

* catch the build error

* remove qna endpoint

* remove console

* add qnaconfig

Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com>
Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
Co-authored-by: Tony Anziano <tonyanziano5@gmail.com>
Co-authored-by: LouisEugeneMSFT <66701106+LouisEugeneMSFT@users.noreply.github.com>
Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: leileizhang <leilzh@microsoft.com>
benbrown pushed a commit to benbrown/BotFramework-Composer that referenced this pull request May 24, 2021
* try-catch around trigger grouping expressions (microsoft#5017)

Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>

* chore: Updated installOneAuth script to target correct version. (microsoft#5020)

* Updated installOneAuth script to target correct version.

* Better refactor

* feat: adaptive expression functions menu (microsoft#5015)

* expressions menu

* Fixing aligment of menu

* PR comments

Co-authored-by: Soroush <hatpick@gmail.com>

* fix: Correct handling of focus for Intellisense fields (microsoft#5039)

* fix

* Improved handling of focus when leveraging an Intellisense suggestion

* comments on wrong lines

* feat: azure publish with orchestrator (microsoft#5011)

* refactor the luis build in azure publish

* update the orchestrator path

* update the cleanup

* fix typo

* catch the build error

* remove qna endpoint

* remove console

* add qnaconfig

Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com>
Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
Co-authored-by: Tony Anziano <tonyanziano5@gmail.com>
Co-authored-by: LouisEugeneMSFT <66701106+LouisEugeneMSFT@users.noreply.github.com>
Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: leileizhang <leilzh@microsoft.com>
benbrown pushed a commit to benbrown/BotFramework-Composer that referenced this pull request May 24, 2021
* try-catch around trigger grouping expressions (microsoft#5017)

Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>

* chore: Updated installOneAuth script to target correct version. (microsoft#5020)

* Updated installOneAuth script to target correct version.

* Better refactor

* feat: adaptive expression functions menu (microsoft#5015)

* expressions menu

* Fixing aligment of menu

* PR comments

Co-authored-by: Soroush <hatpick@gmail.com>

* fix: Correct handling of focus for Intellisense fields (microsoft#5039)

* fix

* Improved handling of focus when leveraging an Intellisense suggestion

* comments on wrong lines

* feat: azure publish with orchestrator (microsoft#5011)

* refactor the luis build in azure publish

* update the orchestrator path

* update the cleanup

* fix typo

* catch the build error

* remove qna endpoint

* remove console

* add qnaconfig

Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com>
Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
Co-authored-by: Tony Anziano <tonyanziano5@gmail.com>
Co-authored-by: LouisEugeneMSFT <66701106+LouisEugeneMSFT@users.noreply.github.com>
Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: leileizhang <leilzh@microsoft.com>
benbrown pushed a commit that referenced this pull request Jun 11, 2021
* try-catch around trigger grouping expressions (#5017)

Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>

* chore: Updated installOneAuth script to target correct version. (#5020)

* Updated installOneAuth script to target correct version.

* Better refactor

* feat: adaptive expression functions menu (#5015)

* expressions menu

* Fixing aligment of menu

* PR comments

Co-authored-by: Soroush <hatpick@gmail.com>

* fix: Correct handling of focus for Intellisense fields (#5039)

* fix

* Improved handling of focus when leveraging an Intellisense suggestion

* comments on wrong lines

* feat: azure publish with orchestrator (#5011)

* refactor the luis build in azure publish

* update the orchestrator path

* update the cleanup

* fix typo

* catch the build error

* remove qna endpoint

* remove console

* add qnaconfig

Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com>
Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
Co-authored-by: Tony Anziano <tonyanziano5@gmail.com>
Co-authored-by: LouisEugeneMSFT <66701106+LouisEugeneMSFT@users.noreply.github.com>
Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: leileizhang <leilzh@microsoft.com>
benbrown pushed a commit that referenced this pull request Jun 11, 2021
* try-catch around trigger grouping expressions (#5017)

Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>

* chore: Updated installOneAuth script to target correct version. (#5020)

* Updated installOneAuth script to target correct version.

* Better refactor

* feat: adaptive expression functions menu (#5015)

* expressions menu

* Fixing aligment of menu

* PR comments

Co-authored-by: Soroush <hatpick@gmail.com>

* fix: Correct handling of focus for Intellisense fields (#5039)

* fix

* Improved handling of focus when leveraging an Intellisense suggestion

* comments on wrong lines

* feat: azure publish with orchestrator (#5011)

* refactor the luis build in azure publish

* update the orchestrator path

* update the cleanup

* fix typo

* catch the build error

* remove qna endpoint

* remove console

* add qnaconfig

Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com>
Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
Co-authored-by: Tony Anziano <tonyanziano5@gmail.com>
Co-authored-by: LouisEugeneMSFT <66701106+LouisEugeneMSFT@users.noreply.github.com>
Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: leileizhang <leilzh@microsoft.com>
benbrown pushed a commit that referenced this pull request Jun 11, 2021
* try-catch around trigger grouping expressions (#5017)

Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>

* chore: Updated installOneAuth script to target correct version. (#5020)

* Updated installOneAuth script to target correct version.

* Better refactor

* feat: adaptive expression functions menu (#5015)

* expressions menu

* Fixing aligment of menu

* PR comments

Co-authored-by: Soroush <hatpick@gmail.com>

* fix: Correct handling of focus for Intellisense fields (#5039)

* fix

* Improved handling of focus when leveraging an Intellisense suggestion

* comments on wrong lines

* feat: azure publish with orchestrator (#5011)

* refactor the luis build in azure publish

* update the orchestrator path

* update the cleanup

* fix typo

* catch the build error

* remove qna endpoint

* remove console

* add qnaconfig

Co-authored-by: Geoff Cox (Microsoft) <gcox@microsoft.com>
Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
Co-authored-by: Tony Anziano <tonyanziano5@gmail.com>
Co-authored-by: LouisEugeneMSFT <66701106+LouisEugeneMSFT@users.noreply.github.com>
Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: leileizhang <leilzh@microsoft.com>
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
…osoft#5020)

* Updated installOneAuth script to target correct version.

* Better refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants