Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: a11y in all-up view #4991

Merged
merged 3 commits into from
Nov 30, 2020
Merged

fix: a11y in all-up view #4991

merged 3 commits into from
Nov 30, 2020

Conversation

zhixzhan
Copy link
Contributor

Description

1. Refine Enter submit in list-view

  • For single line input, press Enter do submit
  • For multiple line input, press Enter do submit, Shift+Enter get a new line,

Task Item

close #4825

Screenshots

image

@coveralls
Copy link

coveralls commented Nov 26, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 55.385% when pulling 64b3172 on zhixzhan/all-up-view-a11y into e4c6c71 on main.

@a-b-r-o-w-n a-b-r-o-w-n self-assigned this Nov 30, 2020
@a-b-r-o-w-n a-b-r-o-w-n added the Approved to merge approved, waiting to be merged label Nov 30, 2020
beyackle
beyackle approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@beyackle beyackle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good use of ?: to make the logic more apparent.

@cwhitten cwhitten merged commit ea34b18 into main Nov 30, 2020
@cwhitten cwhitten deleted the zhixzhan/all-up-view-a11y branch November 30, 2020 17:46
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@zhixzhan @boydc2014 @a-b-r-o-w-n
keyboard Enter submit (microsoft#4991)
4ef7d38 
Co-authored-by: Dong Lei <donglei@microsoft.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

@beyackle beyackle beyackle approved these changes

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@cwhitten cwhitten Awaiting requested review from cwhitten

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@hatpick hatpick Awaiting requested review from hatpick

@srinaath srinaath Awaiting requested review from srinaath

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees

@a-b-r-o-w-n a-b-r-o-w-n

Labels
Approved to merge approved, waiting to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

editing issue (accessibility) in LU/LG table view
6 participants
@zhixzhan @coveralls @a-b-r-o-w-n @beyackle @cwhitten @boydc2014