Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [l10n] Fixes issues with extracting strings particularly in electron package. #4973

Merged
merged 2 commits into from
Nov 24, 2020
Merged

fix: [l10n] Fixes issues with extracting strings particularly in electron package. #4973

merged 2 commits into from
Nov 24, 2020

Conversation

hatpick
Copy link
Contributor

@hatpick hatpick commented Nov 24, 2020

Description

Fixes issues with extracting strings particularly in electron package.

Task Item

#minor

@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 55.444% when pulling f1d1f94 on hatpick:sorgh/fix_l10n_ignores into abb716f on microsoft:main.

@hatpick hatpick merged commit 6097da8 into microsoft:main Nov 24, 2020
@hatpick hatpick deleted the sorgh/fix_l10n_ignores branch November 24, 2020 23:50
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@hatpick
fix: [l10n] Fixes issues with extracting strings particularly in elec…
059d814 
…tron package. (microsoft#4973)

* Clean l10ntemp folder after extraction

* Fix patters l10n electron
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srinaath srinaath srinaath approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@beyackle beyackle Awaiting requested review from beyackle

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@cwhitten cwhitten Awaiting requested review from cwhitten

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hatpick @coveralls @srinaath