Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allows "view dialog" from form dialog schema page #4969

Merged
merged 3 commits into from
Nov 24, 2020
Merged

fix: Allows "view dialog" from form dialog schema page #4969

merged 3 commits into from
Nov 24, 2020

Conversation

hatpick
Copy link
Contributor

@hatpick hatpick commented Nov 24, 2020

Description

Fixes view dialog functionality from the list of form dialog schemas.
Updates bf-generate-library with minor fixes in merge.

Task Item

#minor

@hatpick hatpick added the Area: Form Dialogs The creation of an adaptive dialog from a schema defined by creating a form label Nov 24, 2020
@hatpick hatpick changed the title fix: view dialog from form dialog schema page fix: Allows "view dialog" from form dialog schema page Nov 24, 2020
@coveralls
Copy link

coveralls commented Nov 24, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.003%) to 55.444% when pulling bb786b8 on sorgh/fd_view_dialog into 0907221 on main.

@hatpick hatpick merged commit abb716f into main Nov 24, 2020
@hatpick hatpick deleted the sorgh/fd_view_dialog branch November 24, 2020 21:49
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@hatpick @sorgh
fix: Allows "view dialog" from form dialog schema page (microsoft#4969)
e5c270c 
* Fix form dialog to dialog navigation

* Update fd generate library with minor fixes

Co-authored-by: Soroush Ghorashi <sorgh@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srinaath srinaath srinaath approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@beyackle beyackle Awaiting requested review from beyackle

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@cwhitten cwhitten Awaiting requested review from cwhitten

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
Area: Form Dialogs The creation of an adaptive dialog from a schema defined by creating a form
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hatpick @coveralls @srinaath @sorgh