Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lg api use the wrong offset on the original file #4892

Merged
merged 1 commit into from
Nov 19, 2020
Merged

fix: lg api use the wrong offset on the original file #4892

merged 1 commit into from
Nov 19, 2020

Conversation

lei9444
Copy link
Contributor

@lei9444 lei9444 commented Nov 19, 2020

Description

update the lg lib version.
The root cause is microsoft/botbuilder-js#3077

Task Item

closes #4848

Screenshots

@zhixzhan zhixzhan mentioned this pull request Nov 19, 2020
Merged
@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 54.506% when pulling a98cfb5 on lei9444:fixlg into 737a790 on microsoft:main.

@boydc2014 boydc2014 merged commit 9c53186 into microsoft:main Nov 19, 2020
lei9444 added a commit that referenced this pull request Nov 20, 2020
@lei9444
fix: lg api use the wrong offset on the original file (#4892)
81992df
@lei9444 lei9444 mentioned this pull request Nov 20, 2020
Merged
boydc2014 pushed a commit that referenced this pull request Nov 20, 2020
@lei9444 @zhixzhan
chore: cherry-pick lg and qna commit to v1.2.2 (#4915)
0776c30 
* lazy render qna hidden list item (#4871)

* fix: lg api use the wrong offset on the original file (#4892)

Co-authored-by: Zhixiang Zhan <zhixzhan@microsoft.com>
EricDahlvang pushed a commit that referenced this pull request Nov 27, 2020
@lei9444 @EricDahlvang
fix: lg api use the wrong offset on the original file (#4892)
2cf2e93
@lei9444 lei9444 deleted the fixlg branch February 1, 2021 02:07
benbrown pushed a commit to benbrown/BotFramework-Composer that referenced this pull request May 24, 2021
@lei9444 @EricDahlvang
fix: lg api use the wrong offset on the original file (microsoft#4892)
9732f6e
benbrown pushed a commit that referenced this pull request Jun 11, 2021
@lei9444 @EricDahlvang
fix: lg api use the wrong offset on the original file (#4892)
2189c93
lei9444 added a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@lei9444
fix: lg api use the wrong offset on the original file (microsoft#4892)
4fa28e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boydc2014 boydc2014 boydc2014 approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@beyackle beyackle Awaiting requested review from beyackle

@cwhitten cwhitten Awaiting requested review from cwhitten

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@hatpick hatpick Awaiting requested review from hatpick

@srinaath srinaath Awaiting requested review from srinaath

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

@yeze322 yeze322 Awaiting requested review from yeze322

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Response options are duplicated and/or end up under the wrong response
3 participants
@lei9444 @coveralls @boydc2014