Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: botprojects context menu issues #4866

Merged
merged 20 commits into from
Nov 22, 2020
Merged

fix: botprojects context menu issues #4866

merged 20 commits into from
Nov 22, 2020

Conversation

zhixzhan
Copy link
Contributor

@zhixzhan zhixzhan commented Nov 18, 2020 •
edited
Loading

Description

  1. Fix invalid warning and errors show up in project tree
  2. Fix ProjectTree Popup tooltip text truncation
  3. Fix Links in context menu dont work.

Task Item

close #4811
refs #4853
close #4854

Screenshots

image

@zhixzhan zhixzhan added Area: RuntimeProject Not Targetting Main a pull request created not against main BotProjects Group all Bot projects tickets 1.3 1.3 Release labels Nov 18, 2020
boydc2014
boydc2014 previously approved these changes Nov 20, 2020
View reviewed changes
@boydc2014
Copy link
Contributor

@zhixzhan looks like one last UT is failing

@srinaath
Copy link
Contributor

@zhixzhan These links still dont work for me

@srinaath
Copy link
Contributor

We have an issue with the hover interaction still.

https://microsoft.sharepoint.com/:i:/t/ConversationalAI785/Ef-TO6oI-lxAliy1Dv7unCEBRlRi8fWdJJQgkhT9OwhohQ?e=715ebh

@srinaath
Copy link
Contributor

I think these tickets were supposed to be wrapped in this PR. 

#4920 #4919

@lei9444
Copy link
Contributor

lei9444 commented Nov 21, 2020

I think these tickets were supposed to be wrapped in this PR. 

#4920 #4919

fixed this two

@lei9444
Copy link
Contributor

lei9444 commented Nov 21, 2020

@zhixzhan These links still dont work for me

fixed this one

@lei9444
Copy link
Contributor

lei9444 commented Nov 21, 2020

We have an issue with the hover interaction still.

https://microsoft.sharepoint.com/:i:/t/ConversationalAI785/Ef-TO6oI-lxAliy1Dv7unCEBRlRi8fWdJJQgkhT9OwhohQ?e=715ebh

looks like the target(the icon) is too small, when move away the icon, the tooltip will dismiss

@lei9444
Copy link
Contributor

lei9444 commented Nov 21, 2020

use callout to replace the tooltip
callout

@cwhitten cwhitten merged commit f55001a into feature/bot-projects Nov 22, 2020
@cwhitten cwhitten deleted the zhixzhan/feature/bot-projects-fix branch November 22, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srinaath srinaath srinaath left review comments

@cwhitten cwhitten cwhitten approved these changes

@boydc2014 boydc2014 boydc2014 left review comments

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@beyackle beyackle Awaiting requested review from beyackle

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@hatpick hatpick Awaiting requested review from hatpick

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
1.3 1.3 Release Area: RuntimeProject BotProjects Group all Bot projects tickets Not Targetting Main a pull request created not against main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhixzhan @boydc2014 @srinaath @lei9444 @cwhitten