Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Form dialog fixes requested by UX (melanie) #4860

Merged
merged 5 commits into from
Nov 17, 2020
Merged

fix: Form dialog fixes requested by UX (melanie) #4860

merged 5 commits into from
Nov 17, 2020

Conversation

hatpick
Copy link
Contributor

@hatpick hatpick commented Nov 17, 2020

Description

  1. Shows errors only if the user has touched the form.
  2. Allows pasting comma separated values into the value picker for list values.

Task Item

closes #4846
#4842

@hatpick hatpick added the Area: Form Dialogs The creation of an adaptive dialog from a schema defined by creating a form label Nov 17, 2020
GeoffCoxMSFT
GeoffCoxMSFT previously approved these changes Nov 17, 2020
View reviewed changes
@coveralls
Copy link

coveralls commented Nov 17, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.009%) to 54.465% when pulling 44c260c on hatpick:sorgh/fd_fixes into 053b8ba on microsoft:main.

@hatpick hatpick merged commit 5b6e3d1 into microsoft:main Nov 17, 2020
@hatpick hatpick deleted the sorgh/fd_fixes branch November 17, 2020 23:52
EricDahlvang pushed a commit that referenced this pull request Nov 27, 2020
@hatpick @sorgh @EricDahlvang
fix: Form dialog fixes requested by UX (melanie) (#4860)
6e87c83 
* Update bf-generate-lib

* Form dialog fixes requested by Melanie

* PR comment

Co-authored-by: Soroush Ghorashi <sorgh@microsoft.com>
benbrown pushed a commit to benbrown/BotFramework-Composer that referenced this pull request May 24, 2021
@hatpick @sorgh @EricDahlvang
fix: Form dialog fixes requested by UX (melanie) (microsoft#4860)
88092ec 
* Update bf-generate-lib

* Form dialog fixes requested by Melanie

* PR comment

Co-authored-by: Soroush Ghorashi <sorgh@microsoft.com>
benbrown pushed a commit that referenced this pull request Jun 11, 2021
@hatpick @sorgh @EricDahlvang
fix: Form dialog fixes requested by UX (melanie) (#4860)
b0a1e3b 
* Update bf-generate-lib

* Form dialog fixes requested by Melanie

* PR comment

Co-authored-by: Soroush Ghorashi <sorgh@microsoft.com>
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@hatpick @sorgh
fix: Form dialog fixes requested by UX (melanie) (microsoft#4860)
486cfd8 
* Update bf-generate-lib

* Form dialog fixes requested by Melanie

* PR comment

Co-authored-by: Soroush Ghorashi <sorgh@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeoffCoxMSFT GeoffCoxMSFT GeoffCoxMSFT approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@beyackle beyackle Awaiting requested review from beyackle

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@cwhitten cwhitten Awaiting requested review from cwhitten

@srinaath srinaath Awaiting requested review from srinaath

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees

@GeoffCoxMSFT GeoffCoxMSFT

Labels
Area: Form Dialogs The creation of an adaptive dialog from a schema defined by creating a form
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Form dialogs, schema editor, list property type field: accept a comma-separated list?
4 participants
@hatpick @coveralls @GeoffCoxMSFT @sorgh