feat: Orchestrator Integration #4852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsuwandy
approved these changes
Nov 17, 2020
cwhitten
approved these changes
Nov 17, 2020
hatpick
reviewed
Nov 17, 2020
| const bluFilePath = Path.resolve(this.generatedFolderPath, dialog.id.replace('.lu', '.blu')); | ||
| snapshots[dialog.id.replace('.lu', '').replace(/[-.]/g, '_')] = bluFilePath; | ||
|
|
||
| writeFile(bluFilePath, Buffer.from(dialog.snapshot), (err) => { |
There was a problem hiding this comment.
why not using the "promisified" writeFile from fs-extra and await?
There was a problem hiding this comment.
Thanks @hatpick, I completely missed this. Fixed this and the pathExists function on line 138.
hatpick
reviewed
Nov 17, 2020
| orchestratorSettings.orchestrator.snapshots = snapshots; | ||
| const orchestratorSettingsPath = Path.resolve(this.generatedFolderPath, 'orchestrator.settings.json'); | ||
|
|
||
| writeFile(orchestratorSettingsPath, JSON.stringify(orchestratorSettings), (err) => { |
hatpick
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the full local e2e flow for Orchestrator
What is here:
What isn't:
Task Item
Closes #4390 , #4209
Screenshots