fix: Added better error handling in pva publish extension's publish method #4837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oser into toanzian/fix/pva-err-handling
GeoffCoxMSFT
approved these changes
Nov 17, 2020
cwhitten
approved these changes
Nov 17, 2020
EricDahlvang
pushed a commit
that referenced
this pull request
Nov 27, 2020
benbrown
pushed a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
benbrown
pushed a commit
that referenced
this pull request
Jun 11, 2021
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, in the case that PVA would send back a response other than what was expect (202), we would discard any info in the response and simply display a 500 and say something went wrong.
With this change, we look for the 202, and if we do not receive a 202, we try to surface the response from PVA in the Composer UI.
#minor