chore: update the navigation link for setting page #4827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhixzhan
reviewed
Nov 17, 2020
hatpick
reviewed
Nov 17, 2020
| @@ -57,7 +57,7 @@ export const topLinks = ( | |||
| disabled: !botLoaded, | |||
| }, | |||
| { | |||
| to: `/bot/${projectId}/diagnostics`, | |||
| to: `/bot/${rootProjectId || projectId}/diagnostics`, | |||
There was a problem hiding this comment.
shouldn't this be prioritizing projectId over the rootProjectId? meaning if projectId is there us it, otherwise fall back on the rootProjectId (projectId || rootProjectId)
There was a problem hiding this comment.
Hi, @hatpick The projectId here I think is skillId or rootProjectId, so if the rootProjectId is null, the projectId is root id.
|
@lei9444 is this PR still WIP? should it moved back to draft? |
srinaath
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Task Item
#minor
Screenshots