Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removed some extraneous characters from the downloaded pva zip name #4808

Merged
merged 2 commits into from
Nov 13, 2020

Conversation

tonyanziano
Copy link
Contributor

Some extra, unwanted characters were being added to the end of the downloaded .zip from PVA. This PR removes those characters.

#minor

@coveralls
Copy link

coveralls commented Nov 13, 2020

Coverage Status

Coverage increased (+0.009%) to 54.786% when pulling 1849730 on toanzian/zip-name into 4b573dc on main.

@cwhitten cwhitten merged commit 4caefe5 into main Nov 13, 2020
@cwhitten cwhitten deleted the toanzian/zip-name branch November 13, 2020 23:45
alanlong9278 added a commit to alanlong9278/BotFramework-Composer that referenced this pull request Nov 18, 2020
* feature/bot-projects:
  fix: keep highlight on item with the menu open (microsoft#4835)
  All tests passed
  chore: Pull form dialogs feature branch back to main (microsoft#4841)
  X-platform fix for electron-server "start" script (microsoft#4833)
  build: add option to force rebuild of extensions (microsoft#4830)
  fix: remove checkURL call from navTo on dialog clicks (microsoft#4795)
  fix: export to zip (microsoft#4820)
  fix: prevent minification of AbortSignal (microsoft#4829)
  feat: Settings page (microsoft#4456)
  feat: bot projects skill & context menu (microsoft#4492)
  fix: repair E2E tests that depended on seeing a single bot name (microsoft#4807)
  Removed some extraneous characters from the downloaded pva zip name (microsoft#4808)
  fix: Fixes linux icons on the taskbar (microsoft#4806)
  Update 1.2.0.md
  release: 1.2.0 (microsoft#4796)
  fix: validate bot name when passed via URL params (microsoft#4712)
  fix async move (microsoft#4799)
  fix: Await until delete action finishes (microsoft#4792)
  fix: update debounced update handlers (microsoft#4790)
benbrown pushed a commit to benbrown/BotFramework-Composer that referenced this pull request May 24, 2021
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants