Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing type declarations in 'useDialogEditApi' #4801

Merged
merged 8 commits into from
Nov 17, 2020

Conversation

yeze322
Copy link
Contributor

@yeze322 yeze322 commented Nov 13, 2020

Description

closes #4800

Prevent potential uncaptured async return value usage bugs. Can prevent unexpected value type:

image

image

Task Item

Screenshots

@coveralls
Copy link

coveralls commented Nov 13, 2020

Coverage Status

Coverage decreased (-0.004%) to 54.461% when pulling 4d21014 on yeze322:types/dialogApi into f9c6e5e on microsoft:main.

@a-b-r-o-w-n a-b-r-o-w-n added the 1.3 1.3 Release label Nov 13, 2020
@a-b-r-o-w-n a-b-r-o-w-n merged commit 053b8ba into microsoft:main Nov 17, 2020
EricDahlvang pushed a commit that referenced this pull request Nov 27, 2020
* fix async move

* add type declarations for useDialogEditApi

* fix ts type

Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>
benbrown pushed a commit to benbrown/BotFramework-Composer that referenced this pull request May 24, 2021
…#4801)

* fix async move

* add type declarations for useDialogEditApi

* fix ts type

Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>
benbrown pushed a commit that referenced this pull request Jun 11, 2021
* fix async move

* add type declarations for useDialogEditApi

* fix ts type

Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
…#4801)

* fix async move

* add type declarations for useDialogEditApi

* fix ts type

Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.3 1.3 Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing type declarations in the hook useDialogEditApi
5 participants