feat: Property Editor Header when botname is selected in Project tree #4771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 10, 2020 16:23
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
…soft/BotFramework-Composer into feature/propertyEditorHeader Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> # Conflicts: # Composer/packages/client/src/pages/design/DesignPage.tsx
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
hatpick
reviewed
Nov 11, 2020
Composer/packages/client/src/pages/design/PropertyEditorHeader.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
|
@zhixzhan tests dont pass on ur branch. I think its safe to take this PR into ur branch when u feel its comfortable as i made sure no new tests fail because of this branch. |
hatpick
approved these changes
Nov 12, 2020
srinaath
added a commit
that referenced
this pull request
Nov 14, 2020
* Added schema for bot project support Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Added support to handle botproject space Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * More updates Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * temp Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Loading multiple projects working effeiciently Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Backup Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> creat new bot Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Bot project file Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * More updates Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * More updates Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * update the recoil to 0.0.13 * fix lint * remove @type/recoil * router work Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Bot Project file creation, adding remote/local skills. Populate state management with rootbot and skills * Migrate to old desing page and project tree Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Revert usage of React 16.13.1 to 16.13.0 Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Revert "Revert usage of React 16.13.1 to 16.13.0" This reverts commit 9aa46ca. * Rename api handlers Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Add existing skill tests passing Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Add 1.0 botproject schema Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Fix typo Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Manifest tests updated Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> More updates Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Revert publish console logs Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> All unit tests added Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Removed code for bot migration Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Server side tests added Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Updated schema url to the correct one Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Fix lint and update schema url on echobot Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * botstates Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> More file util tests added Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Support for exporting .botproj file Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Clean up paths Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Spellings cleanup Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Updated gitignore Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Typo fixed Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Set project ignore validation to true while opening remote skill Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Following sdk.schema approach to specificy object type using ref Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Runtime start first pass Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> skills update Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Migration of old bot wrapped up Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Runtime start updates Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Bot load status Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Bot status indicator Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Notification selector Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Update to settings Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Working bot status indicator Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Update to start component Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Stable LocalBotRuntime operations Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * add/remote skill sync to *.botproj file * relative path support bp file Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Path set Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Fix schema Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Removed workspace references. Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Relative path support Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * creation flow of add/open skill bot, remote skill * Update operations on Bot project file Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Updated runtime code Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * clean up * Start bots panel first pass completed Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Updated tests for removing workspace reference Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Removed manifest update operation Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Cleared logs Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Remove skill references Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Remove skill references Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Tested Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Remove unused references Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Update references Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Updated runtime experience Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * repair broken link modal * update the recognizer types generate function * repair broken skill link * Safe removal of skills Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Resolve bugs with $kind Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * check LUIS & QnA key * add diagnostics to botProjectSpaceSelector * diagnostics in projectree * safely remove unused refs Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Handle select skill dialog tests Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> All tests passing Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Removed logs Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Skill utils updated Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * diagnostics style in project tree * context menu in project tree * update * Added more unit tests Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Added back file to get it back to main version Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Bot status tracker operation Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> More test updated Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * More tests added Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Moved test files Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Binding skill host endpoint on bot start Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Added aria labels Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Header tests updated Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * cleaned up tests and rebased main Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * yarn update and header test Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * PR cleanup before moving from draft status Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * package all setting check into botindexer.validate * update * Migration completed Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Updated yarn.lock on vacore Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Revert azure publish yarn lock Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * remove fit from test Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Update settings on removing a skill Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Logic update for skill deletion Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Add get port to server Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Start root bot if skills are not present Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * trigger dispatcher * context menu button enable * start/stop bot in project tree * edit/create manifest * Create/edit skill manifest modal * clean up qnaKbUrls * creation flow in design page * update broken skill repair modal * feat: local bot controller * fet: Add test in emulator column * Updated select skill dialog to disable controls if no skill Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * open emulator test * Added fnd by role Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * open Emulator test updates Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Update to skills Utils Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * update error message style * Support skillhost endpoint for remote skills Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * edit skill manifest in edit mode * fix menu flash * Port set Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Update yarn lock Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * remote skill manifest editor * refine broken bot * fixed styles * tests * tests * Unit tests completed Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * resolve merge conflict * navigation and visual editor for remote skill * lint fix * resolve merge conflict * update * update * get bot diagnostics when load bot * update * move skillsProjectIdSelector to selectors/skills * navigate to skill bot, update test * feat: Property Editor Header when botname is selected in Project tree (#4771) * Support undo/redo for skill Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Poprety Editor commits Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Adaptive form updates Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * PropertyEditorHeader test Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Updated tests Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * PropertyEditor wrapped up Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Removed unused props Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com> * clean up * move PropertyEditorHeader.test.tsx to client/design * clean up * clean up qnaKbUrls * resolve merge conflict * clean up * clean * validation from settings * ut for trigger dispatcher * fix e2e tests and update the dialog create logic * fix unit tests * fix create bot error * change the warning and error position * fix navigate error when create a new dialog * update * update link * Header update Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * Adjust styles Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * bot check filter empty qna/lu files * context menu in project tree header * update * Updated styles Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: Leilei Zhang <leilzh@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com> Co-authored-by: TJ <tj.durnford@microsoft.com> Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a header to the property editor when the botname is clicked in the project tree and no dialogs are selected. Default routing to main dialog is stopped.
Fixes #4753