Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change remote template to use preview package in public feed #4739

Merged
merged 3 commits into from
Nov 18, 2020

Conversation

pavolum
Copy link
Contributor

@pavolum pavolum commented Nov 10, 2020

Description

Currently the Conversational Core template is stored as a dot net template within a package in a private NuGet feed. This PR changes the package reference so the same template is grabbed from the public package. This will facilitate end user use of this template in 1.3 without auth issues.

Task Item

fixes #4729

@coveralls
Copy link

coveralls commented Nov 10, 2020

Coverage Status

Coverage remained the same at 54.456% when pulling 63d2f52 on pavolum/updateRemoteTemplate into 5b6e3d1 on main.

@a-b-r-o-w-n a-b-r-o-w-n added the 1.3 1.3 Release label Nov 13, 2020
@cwhitten cwhitten merged commit 88e7d04 into main Nov 18, 2020
@cwhitten cwhitten deleted the pavolum/updateRemoteTemplate branch November 18, 2020 00:39
EricDahlvang pushed a commit that referenced this pull request Nov 27, 2020
Co-authored-by: Patrick Volum <pavolum@microsoft.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
benbrown pushed a commit to benbrown/BotFramework-Composer that referenced this pull request May 24, 2021
…t#4739)

Co-authored-by: Patrick Volum <pavolum@microsoft.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
benbrown pushed a commit that referenced this pull request Jun 11, 2021
Co-authored-by: Patrick Volum <pavolum@microsoft.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
…t#4739)

Co-authored-by: Patrick Volum <pavolum@microsoft.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.3 1.3 Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Conversation Core remote template reference to public version
5 participants