feat: Diagnostics Page #4457
Merged
feat: Diagnostics Page #4457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srinaath
reviewed
Oct 27, 2020
| @@ -59,7 +59,7 @@ export const TestController: React.FC<{ projectId: string }> = (props) => { | |||
| const [calloutVisible, setCalloutVisible] = useState(false); | |||
|
|
|||
| const botActionRef = useRef(null); | |||
| const notifications = useNotifications(projectId); | |||
| const notifications = useRecoilValue(allDiagnosticsSelector); | |||
There was a problem hiding this comment.
This change needs to be ported over because of this. Based on which PR gets merged first we can decide who does the port.
srinaath
reviewed
Oct 27, 2020
srinaath
reviewed
Oct 27, 2020
Composer/packages/client/src/recoilModel/selectors/diagnosticsPageSelector.ts
Show resolved
Hide resolved
srinaath
reviewed
Oct 27, 2020
Composer/packages/client/src/pages/diagnostics/DiagnosticFilter.tsx
Outdated
Show resolved
Hide resolved
srinaath
reviewed
Oct 27, 2020
Composer/packages/client/src/pages/diagnostics/DiagnosticFilter.tsx
Outdated
Show resolved
Hide resolved
srinaath
reviewed
Oct 27, 2020
Composer/packages/client/src/pages/diagnostics/DiagnosticFilter.tsx
Outdated
Show resolved
Hide resolved
srinaath
reviewed
Oct 27, 2020
Composer/packages/client/src/pages/diagnostics/DiagnosticFilter.tsx
Outdated
Show resolved
Hide resolved
srinaath
reviewed
Oct 27, 2020
srinaath
requested changes
Oct 27, 2020
* Update en-US.json * bring in stuff from the draft branch * make deletion work * add error/warning icons * read notification map for state * fix type-checking and start on unit tests * add sampleDialog and fix more tests * add showAll * rename to onAllSelected because it's a callback * update unit tests * fix onSelect handling in ProjectTree * Update qna.test.tsx * Update design.test.tsx * add unit test * fixes from PR comments * restore multibots to tree * fix links from project tree * fix wrong IDs in URL * yarn.lock rebuild * update yarn.lock files * fix action card links * Update DesignPage.tsx * fix unit test * add unit test to ExpandableNode * update ProjectTree unit tests * Update ExpandableNode.tsx * add rootProjectId to triggerApi * fix creation and deletion bugs * change mocks folder name * Load design page only after skill project is loaded Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> * fixes from CR * fix more tests * fix: handle the case when selection is not empty (microsoft#4561) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * delete fd (microsoft#4556) Co-authored-by: Soroush <sorgh@microsoft.com> * fix more unit tests * revert: bf-orchestrator lib integration (microsoft#4568) This reverts commit 006a589. Co-authored-by: Andy Brown <asbrown002@gmail.com> * fix test typol * ci: remove code scanning workflow (microsoft#4569) * fix: Can not add properties in "SetProperties" action (microsoft#4572) * bug fix * pr comment * pr comments Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: zeye <zeye@microsoft.com> Co-authored-by: Soroush <hatpick@gmail.com> Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: taicchoumsft <61705609+taicchoumsft@users.noreply.github.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: LouisEugeneMSFT <66701106+LouisEugeneMSFT@users.noreply.github.com>
This reverts commit c401768.
|
This pull request introduces 1 alert when merging 26e26e4 into 296e2b8 - view on LGTM.com new alerts:
|
|
This PR is looking good. One functionality to add is on the DesignPage the errors and warnings across all bots needs to be surfaced. Once thats added we can merge it |
Hi, @srinaath I have updated the warnings in the Design and added more unit tests. |
srinaath
previously approved these changes
Nov 9, 2020
boydc2014
approved these changes
Nov 11, 2020
alanlong9278
added a commit
to alanlong9278/BotFramework-Composer
that referenced
this pull request
Nov 12, 2020
* settingsPage: remove useless files Corrected types Support undo/redo for skill (microsoft#4754) fix UT feat: Diagnostics Page (microsoft#4457) set defaultLanguage as active language if active language is deleted fix: correct URL when switching page modes (microsoft#4736) fix: do not stub __dirname for node extensions (microsoft#4749) chore: bundle extensions (microsoft#4745) fix: Delete & Undo on actions with LG templates doesn't bring back the LG content (microsoft#4740) feat: update sdk package to 4.11.0 (microsoft#4741)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update diagnostics page to support mutli-bot
Task Item
closes #4338
Screenshots