feat: Customized functions in runtime should pass validation and be allowed to start bot #4356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llowed to start bot
cwhitten
previously approved these changes
Oct 13, 2020
|
Current in master, I think we ignore the error of undefined functions, right? So some customer may not aware of they are using a customized functions. So can we at least make sure we don't break MeetAssitant, maybe give them a list of functions they need to add? And we also need to have the error message clear and helpful saying that they need to add unknown functions in settings. |
|
@lei9444 can you address conflicts please |
a-b-r-o-w-n
reviewed
Nov 17, 2020
Composer/packages/lib/indexers/src/validations/expressionValidation/validation.ts
Outdated
Show resolved
Hide resolved
|
ping @lei9444 |
|
FYI @zxyanliu. let's add docs work item to explain this new feature |
|
overriding the E2E test failure. It looks like a cache issue with the devops agent. |
cwhitten
approved these changes
Nov 29, 2020
|
FYI. The doc on this feature has been merged to master. The content will go live soon. |
|
Hi @zxyanliu |
lei9444
added a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…llowed to start bot (microsoft#4356) * feat: Customized functions in runtime should pass validation and be allowed to start bot * update the error message * fix comment * add * match for custom function Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a settings field "customizedFunctions" to allow user to config a list of functions name that is customized and should be ignored in validation phase.
Task Item
closes #3656
refs #3130
Screenshots