-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Disable the default timeout for requests on the LU build #4295
Conversation
…step which can take > 2 minutes for large models
Although this addresses #4294, we should attempt to refactor this endpoint to better fit long processes, like polling or web socket. |
I agree @a-b-r-o-w-n and have a proposal that I will follow up with ASAP. In short: we already implement a polling procedure for the publishing. I would like to formalize this so that publishing, provisioning, and building can take advantage of the same subsystem. |
@benbrown that's good to hear. |
Test environment is failing with: TypeError: req.setTimeout is not a function
Maybe we need to shim this api in the test runner? |
@benbrown i don't know why tests are failing but it seems specific to this change |
@cwhitten I think I found it. Just pushed a small change to the test. |
* Fix #4294 - Disable the default timeout for requests on the LU build step which can take > 2 minutes for large models * update mocked request object to contain settimeout Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
…oft#4295) * Fix microsoft#4294 - Disable the default timeout for requests on the LU build step which can take > 2 minutes for large models * update mocked request object to contain settimeout Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* Fix #4294 - Disable the default timeout for requests on the LU build step which can take > 2 minutes for large models * update mocked request object to contain settimeout Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
…oft#4295) * Fix microsoft#4294 - Disable the default timeout for requests on the LU build step which can take > 2 minutes for large models * update mocked request object to contain settimeout Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Description
This removes the timeout behavior on the /build endpoint, which can result in a network error when publishing a large language model. By default, Node's HTTP server class is set to timeout after 2 minutes.
https://nodejs.org/dist/latest-v6.x/docs/api/http.html#http_server_settimeout_msecs_callback
Task Item
fixes #4294