Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: "Reloading" spin forever when restart bot #3931

Merged
merged 2 commits into from
Aug 28, 2020
Merged

Conversation

VanyLaw
Copy link
Contributor

@VanyLaw VanyLaw commented Aug 28, 2020

Description

Move botStatusInterval out of TestController component, to make sure it won't create duplicated every time component reloaded.

Task Item

close #3930

Screenshots

@github-actions
Copy link

Coverage Status

Coverage increased (+0.003%) to 56.744% when pulling 17d1e6f on wenyluo/fixloading into c310a6c on main.

@hibrenda
Copy link
Contributor

Verified. Issue fixed.

@boydc2014 boydc2014 merged commit d189440 into main Aug 28, 2020
@boydc2014 boydc2014 deleted the wenyluo/fixloading branch August 28, 2020 10:56
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* remove stopPollingRuntime after publish luisand qna

* make botStatusInterval outof component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Reloading" spin for ever but bot is already started
3 participants