feat: Plumbs UpdateActivity and DeleteActivity into the app #3887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-b-r-o-w-n
reviewed
Aug 24, 2020
| "label": "Delete a property", | ||
| "subtitle": "Delete Property" | ||
| } | ||
| }, |
| "form": { | ||
| "label": "Delete activity" | ||
| } | ||
| }, |
There was a problem hiding this comment.
Let's make sure this gets added to the SDK component schemas.
There was a problem hiding this comment.
| @@ -163,4 +163,12 @@ export const DefaultMenuSchema: MenuUISchema = { | |||
| label: formatMessage('Emit a telemetry track event'), | |||
| submenu: [SubmenuNames.Debugging], | |||
| }, | |||
| [SDKKinds.UpdateActivity]: { | |||
| label: formatMessage('Update activity'), | |||
| submenu: [SubmenuNames.PropertyManagement], | |||
There was a problem hiding this comment.
Is this in the right submenu?
There was a problem hiding this comment.
There wasn't an exiting menu that felt great. Any ideas?
a-b-r-o-w-n
approved these changes
Aug 24, 2020
|
@cwhitten we are going to retire the |
|
How should we use these new actions? We need to get the activity ID from an earlier activity, but the suggested dialog.lastActivityId doesn't exist. |
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…t#3887) * Plumbs UpdateActivity and DeleteActivity into the app * Remove duplicate entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3874
note: it still isn't clear where UI is getting component information (label, title, description, etc)