Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: keep user settings in localStorage as well as recoil #3825

Merged
merged 1 commit into from
Aug 10, 2020
Merged

fix: keep user settings in localStorage as well as recoil #3825

merged 1 commit into from
Aug 10, 2020

Conversation

beyackle
Copy link
Contributor

Description

This change lets the user's settings stay around in localStorage, which is then used to initialize the Recoil store. Without it, the preferences would last through a session but then disappear on reload.

Task Item

fixes #3824

Screenshots

image

@cwhitten cwhitten merged commit 66f5d14 into main Aug 10, 2020
@cwhitten cwhitten deleted the beyackle/userSettingStorage branch August 10, 2020 23:16
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 56.425% when pulling 83a1848 on beyackle/userSettingStorage into 0b3381d on main.

alanlong9278 added a commit that referenced this pull request Aug 11, 2020
@alanlong9278
Merge branch 'main' into qna-recognizer
cc8d70b 
* main:
  Update user.ts (#3825)
  do not force dialog name to lowercase (#3817)
  fix: lg editor validation error & intelligence (#3816)
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@beyackle
Update user.ts (microsoft#3825)
24dc906
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhitten cwhitten cwhitten approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@srinaath srinaath Awaiting requested review from srinaath

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

user settings are no longer being written to local storage
3 participants
@beyackle @coveralls @cwhitten