Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: provide error detail in popup. #3755

Merged
merged 6 commits into from
Aug 4, 2020
Merged

feat: provide error detail in popup. #3755

merged 6 commits into from
Aug 4, 2020

Conversation

zhixzhan
Copy link
Contributor

@zhixzhan zhixzhan commented Jul 31, 2020 •
edited
Loading

Description

Task Item

close #3409
close #3771

Screenshots

Untitled4

@zhixzhan zhixzhan requested a review from VanyLaw July 31, 2020 07:40
@coveralls
Copy link

coveralls commented Jul 31, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 57.228% when pulling bd59690 on zhixzhan:error-detail into cf0bcbd on microsoft:main.

@zhixzhan
Copy link
Contributor Author

zhixzhan commented Aug 4, 2020 •
edited
Loading

Hi @vivekkshankar , I'm adding a 'Details' collapse in the black area, to provide more information when user report bug.
Do you think it make sense or should have a better design ?

@cwhitten cwhitten merged commit f47b479 into microsoft:main Aug 4, 2020
@cwhitten
Copy link
Member

cwhitten commented Aug 4, 2020

@zhixzhan @vivekkshankar I went ahead and took this but I agree that we should take a design/UX pass on rendering error messages

@zhixzhan zhixzhan deleted the error-detail branch August 5, 2020 01:16
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@zhixzhan @cwhitten
feat: provide error detail in popup. (microsoft#3755)
efb77f1 
* provide error detail in popup

* code refine

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeze322 yeze322 yeze322 left review comments

@cwhitten cwhitten cwhitten approved these changes

@VanyLaw VanyLaw Awaiting requested review from VanyLaw

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@beyackle beyackle Awaiting requested review from beyackle

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@srinaath srinaath Awaiting requested review from srinaath

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Something went wrong in editing SendResponse for HeroCard Something went wrong
4 participants
@zhixzhan @coveralls @cwhitten @yeze322