-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Intellisense for Composer #3743
Conversation
# Conflicts: # Composer/packages/extensions/adaptive-form/src/components/fields/index.ts # Composer/packages/extensions/adaptive-form/src/utils/resolveFieldWidget.ts # Composer/packages/ui-plugins/composer/package.json
I love the What about
Going from: <IntellisenseTextField {...} />
<IntellisenseInputControl2 {...} />
<IntellisenseInputControl3 {...} />
<IntellisenseInputControl4 {...} />
<IntellisenseInputControl5 {...} /> to const [foo, setFoo] = useIntellisense(...)
<TextField {...} />
const [foo, setFoo] = useIntellisense(...)
<InputControl2 {...} />
const [foo, setFoo] = useIntellisense(...)
<InputControl3 {...} />
const [foo, setFoo] = useIntellisense(...)
<InputControl4 {...} />
const [foo, setFoo] = useIntellisense(...)
<InputControl5 /> |
Hi @cwhitten There are a few challenges with this approach, I am curious to have your opinion on them:
One thing I was considering for a more reusable component was to abstract away the fabric textfield, and take an extra optional input to overwrite a default un-opinionated textfield. Something like: Happy to chat about those things in person |
...packages/extensions/adaptive-form/src/components/fields/ExpressionField/ExpressionEditor.tsx
Outdated
Show resolved
Hide resolved
...packages/extensions/adaptive-form/src/components/fields/ExpressionField/ExpressionEditor.tsx
Outdated
Show resolved
Hide resolved
...packages/extensions/adaptive-form/src/components/fields/ExpressionField/ExpressionEditor.tsx
Show resolved
Hide resolved
Composer/packages/extensions/adaptive-form/src/components/fields/index.ts
Show resolved
Hide resolved
Composer/packages/extensions/intellisense/src/components/CompletionElement.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/intellisense/src/components/CompletionElement.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/intellisense/src/components/CompletionElement.tsx
Show resolved
Hide resolved
Composer/packages/extensions/intellisense/src/components/CompletionElement.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/intellisense/src/components/CompletionElement.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/intellisense/src/components/CompletionList.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/intellisense/src/components/IntellisenseTextField.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/intellisense/src/components/IntellisenseTextField.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/extensions/intellisense/src/hooks/useLanguageServer.ts
Show resolved
Hide resolved
Composer/packages/extensions/intellisense/src/hooks/useLanguageServer.ts
Show resolved
Hide resolved
Composer/packages/extensions/intellisense/src/hooks/useLanguageServer.ts
Show resolved
Hide resolved
Composer/packages/extensions/intellisense/src/hooks/useLanguageServer.ts
Show resolved
Hide resolved
Composer/packages/tools/language-servers/intellisense/package.json
Outdated
Show resolved
Hide resolved
Composer/packages/tools/language-servers/intellisense/src/resolvers/expressions.ts
Outdated
Show resolved
Hide resolved
Composer/packages/tools/language-servers/intellisense/src/utils/intellisenseServerUtils.ts
Show resolved
Hide resolved
Composer/packages/tools/language-servers/intellisense/src/utils/intellisenseServerUtils.ts
Show resolved
Hide resolved
Composer/packages/tools/language-servers/intellisense/tsconfig.build.json
Show resolved
Hide resolved
Composer/packages/extensions/intellisense/src/components/IntellisenseTextField.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/tools/language-servers/intellisense/src/intellisenseServer.ts
Outdated
Show resolved
Hide resolved
* Adding Intellisense server * Adding Intelissense component * Integrating Intellisense for "Properties" Setters and Expressions * Merge update and dependency fix * Lint issues * pr comments * PR comments (2) * Adding id to textfield * bug fix * fixing require vs import * Abstracting built in functions away from lg * Fixing some bugs introduced after adressing PR comments * Using render props * Adding tests for intellisense server * Adding tests for intellisense ui component * Fixing an e2e test * lint Co-authored-by: Louis Eugene <leugene@microsoft.com>
Description
Adding Intellisense to Composer textfields.
This PR includes:
Task Item
fixes #3663
fixes #3664
fixes #3665
Screenshots