fix: fix deploy issue because botproject files structure changed #3719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwhitten
approved these changes
Jul 27, 2020
benbrown
pushed a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
* main: fix: allow storage implementation to determine writability (microsoft#3630) fix: fix deploy issue because botproject files structure changed (microsoft#3719) fix: loop infinitely on publish page when get publish status (microsoft#3716)
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…rosoft#3719) * fix files structure change * add botProject interface and move some interface into shared folder * fix lint Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reason: Because files property in botproject is modified to Map and private, so it cause issue in azure plugin.
Solution: add botproject interface and move some other interfaces to shared folder. Change project type from any to IBotproject.
Task Item
close #3717
Screenshots