Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: let Flow Editor's focus border fullfill its view box #3605

Merged
merged 4 commits into from
Jul 9, 2020
Merged

fix: let Flow Editor's focus border fullfill its view box #3605

merged 4 commits into from
Jul 9, 2020

Conversation

yeze322
Copy link
Contributor

@yeze322 yeze322 commented Jul 9, 2020 •
edited
Loading

Description

closes #3527

Problem: Due to browser behavior limitation, keyboard events can only be captured when a div is being focused. Therefore, where we bind the shortcust listeners, where the focus border appears. As a result, the shortcut listener was bound to a improper div, led to the style issue described in #3527.

Fix: Bind shortcut listeners to higher level component (the <AdaptiveFlowEditor/>), then the focus border should be displayed correctly.

image

Changes:

  1. Bind shortcust handlers in <AdaptiveFlowEditor /> instead of '
  2. Found the scrollIntoView brought unhappy scroll experiecen, conditionally use the scrollIntoViewIfNeeded api instead.

Task Item

Screenshots

@yeze322 yeze322 mentioned this pull request Jul 9, 2020
Closed
@yeze322 yeze322 changed the title fix: let Flow Editor's focus border fullfill the screen fix: let Flow Editor's focus border fullfill its view box Jul 9, 2020
@coveralls
Copy link

coveralls commented Jul 9, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 53.608% when pulling 392554a on visual/focus-zone into 8208fbd on master.

@cwhitten cwhitten merged commit 27a1531 into master Jul 9, 2020
@cwhitten cwhitten deleted the visual/focus-zone branch July 9, 2020 16:47
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@yeze322 @cwhitten
fix: let Flow Editor's focus border fullfill its view box (microsoft#…
b7f5df8 
…3605)

* hoist kbd handlers to editor layer

* conditional scrollIntoView to bring smooth nav exp

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhitten cwhitten cwhitten approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@beyackle beyackle Awaiting requested review from beyackle

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Visual Editor border does not stay in a fixed position
3 participants
@yeze322 @coveralls @cwhitten