Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: link the app insights keys with bot service in provision script #3425

Merged
merged 3 commits into from
Jun 22, 2020
Merged

feat: link the app insights keys with bot service in provision script #3425

merged 3 commits into from
Jun 22, 2020

Conversation

zidaneymar
Copy link
Contributor

@zidaneymar zidaneymar commented Jun 17, 2020 •
edited
Loading

Description

Add the application insights for bot service.
Refer to this doc
Changes:
If user pass the createAppInsights=true to provision script, the script will do another three things:

  1. create application insights instance
  2. create application insights api keys
  3. update app insights 'instrumentation key', 'id', 'api key' to the bot service

Task Item

Closes #3093

Screenshots

After the provision, the bot service would look like this:
image

@coveralls
Copy link

coveralls commented Jun 17, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 48.094% when pulling 5804697 on qika/appinsights into c68a188 on master.

@zidaneymar zidaneymar mentioned this pull request Jun 18, 2020
Closed
@cwhitten cwhitten merged commit fb24331 into master Jun 22, 2020
@cwhitten cwhitten deleted the qika/appinsights branch June 22, 2020 20:33
beyackle added a commit that referenced this pull request Jun 29, 2020
@beyackle @hatpick
@sorgh @cwhitten @yeze322 @VanyLaw @zxyanliu @boydc2014 @LouisEugeneMSFT @lei9444 @a-b-r-o-w-n @tdurnford @tonyanziano @zhixzhan @liweitian
chore: merge latest master into multibot branch (#3518)
9086ad4 
* link the application keys with bot service in provision script (#3425)

* fix: #3309 Allow configuring app settings without opening a bot project (#3454)

* issues#3309

* fixes lints

* Default to bot settings if no route cache

Co-authored-by: Soroush <sorgh@microsoft.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>

* feat: 'Ctrl + Click', 'Shift + Click' behaviors in Flow Editor (#3448)

* ctrl + click behavior

* enhance the focus behavior

* range selection e2e

* calculate accurate range selection

* MacOS Meta + Click support

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>

* fix: fix relative path of runtime folder in eject customized (#3434)

* fix runtime relative path in eject

* fix process pid not exist when runtime folder not exist

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>

* fix: typo (#3474)

* Fix a typo

Message recieved -> Message received

* Improve language

A basic brush of the Home page.

* fix: fix get history before file persistence (#3440)

* fix get history before file persistence

* flush in action not in component

* fix bug

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: Dong Lei <donglei@microsoft.com>

* fix: #2692 Tabbing / clicking / returning out of a number field round your input (#3427)

* bug fix

* pr comment

* lint

* double export

* updated test

Co-authored-by: Louis Eugene <leugene@microsoft.com>
Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>

* fix: revert plugins out of workspace (#3479)

* revert commit about add plugins into workspace

* revert other relative path change

* update the lock file

* remove yarn.lock in azure plugins to make sure bot-deploy updated

Co-authored-by: leilzh <leilzh@microsoft.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>

* chore: Hide ignored folders in vscode, update prettier config (#3493)

* issues#3309

* fixes lints

* Default to bot settings if no route cache

* fix: #3485

Co-authored-by: Soroush <sorgh@microsoft.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>

* feat: show 'AutoEndDialog' from Adaptive Dialog Property Editor (#3498)

* refactor: add rule and remove dangling underscores (#3496)

* add rule and remove dangling underscores

* update elliptic and test

Co-authored-by: Andy Brown <asbrown002@gmail.com>

* chore: added config to debug Electron main process. (#3501)

Co-authored-by: Andy Brown <asbrown002@gmail.com>

* Merge pull request #3502 from hatpick/master

fix: #3486 Debug/Fix HMR support

* fix: add logo-clicking to tests (#3500)

* add logo-clicking to tests

* bump elliptic version

* Update yarn.lock

Co-authored-by: Andy Brown <asbrown002@gmail.com>

* feat: support validate lg custom functions (#3273)

* fix: support validate lg custom functions and separate the dialog validation from parser

* use file name as namespace

* add unit test

* fix lint

* fix: inline editing LU mess up whole file (#3478)

* upgrade lu packages

* update package

* clean

* update

* clean up

Co-authored-by: Andy Brown <asbrown002@gmail.com>

* refactor: change term primary key to authoring key (#3516)

Co-authored-by: Andy Brown <asbrown002@gmail.com>

Co-authored-by: Qi Kang <kangqidev@gmail.com>
Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: Soroush <sorgh@microsoft.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: zeye <2295905420@qq.com>
Co-authored-by: VanyLaw <wenyluo@microsoft.com>
Co-authored-by: Yan Liu <32497439+zxyanliu@users.noreply.github.com>
Co-authored-by: Dong Lei <donglei@microsoft.com>
Co-authored-by: LouisEugeneMSFT <66701106+LouisEugeneMSFT@users.noreply.github.com>
Co-authored-by: Louis Eugene <leugene@microsoft.com>
Co-authored-by: leilzh <leilzh@microsoft.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>
Co-authored-by: TJ Durnford <tjdford@gmail.com>
Co-authored-by: Tony Anziano <toanzian@microsoft.com>
Co-authored-by: Zhixiang Zhan <zhixzhan@microsoft.com>
Co-authored-by: liweitian <liweitian93@outlook.com>
@cwhitten cwhitten mentioned this pull request Jul 8, 2020
Merged
benbrown pushed a commit to benbrown/BotFramework-Composer that referenced this pull request May 24, 2021
@beyackle @hatpick
@sorgh @cwhitten @yeze322 @VanyLaw @zxyanliu @boydc2014 @LouisEugeneMSFT @lei9444 @a-b-r-o-w-n @tdurnford @tonyanziano @zhixzhan @liweitian
chore: merge latest master into multibot branch (microsoft#3518)
a27a8ae 
* link the application keys with bot service in provision script (microsoft#3425)

* fix: microsoft#3309 Allow configuring app settings without opening a bot project (microsoft#3454)

* issues#3309

* fixes lints

* Default to bot settings if no route cache

Co-authored-by: Soroush <sorgh@microsoft.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>

* feat: 'Ctrl + Click', 'Shift + Click' behaviors in Flow Editor (microsoft#3448)

* ctrl + click behavior

* enhance the focus behavior

* range selection e2e

* calculate accurate range selection

* MacOS Meta + Click support

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>

* fix: fix relative path of runtime folder in eject customized (microsoft#3434)

* fix runtime relative path in eject

* fix process pid not exist when runtime folder not exist

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>

* fix: typo (microsoft#3474)

* Fix a typo

Message recieved -> Message received

* Improve language

A basic brush of the Home page.

* fix: fix get history before file persistence (microsoft#3440)

* fix get history before file persistence

* flush in action not in component

* fix bug

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: Dong Lei <donglei@microsoft.com>

* fix: microsoft#2692 Tabbing / clicking / returning out of a number field round your input (microsoft#3427)

* bug fix

* pr comment

* lint

* double export

* updated test

Co-authored-by: Louis Eugene <leugene@microsoft.com>
Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>

* fix: revert plugins out of workspace (microsoft#3479)

* revert commit about add plugins into workspace

* revert other relative path change

* update the lock file

* remove yarn.lock in azure plugins to make sure bot-deploy updated

Co-authored-by: leilzh <leilzh@microsoft.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>

* chore: Hide ignored folders in vscode, update prettier config (microsoft#3493)

* issues#3309

* fixes lints

* Default to bot settings if no route cache

* fix: microsoft#3485

Co-authored-by: Soroush <sorgh@microsoft.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>

* feat: show 'AutoEndDialog' from Adaptive Dialog Property Editor (microsoft#3498)

* refactor: add rule and remove dangling underscores (microsoft#3496)

* add rule and remove dangling underscores

* update elliptic and test

Co-authored-by: Andy Brown <asbrown002@gmail.com>

* chore: added config to debug Electron main process. (microsoft#3501)

Co-authored-by: Andy Brown <asbrown002@gmail.com>

* Merge pull request microsoft#3502 from hatpick/master

fix: microsoft#3486 Debug/Fix HMR support

* fix: add logo-clicking to tests (microsoft#3500)

* add logo-clicking to tests

* bump elliptic version

* Update yarn.lock

Co-authored-by: Andy Brown <asbrown002@gmail.com>

* feat: support validate lg custom functions (microsoft#3273)

* fix: support validate lg custom functions and separate the dialog validation from parser

* use file name as namespace

* add unit test

* fix lint

* fix: inline editing LU mess up whole file (microsoft#3478)

* upgrade lu packages

* update package

* clean

* update

* clean up

Co-authored-by: Andy Brown <asbrown002@gmail.com>

* refactor: change term primary key to authoring key (microsoft#3516)

Co-authored-by: Andy Brown <asbrown002@gmail.com>

Co-authored-by: Qi Kang <kangqidev@gmail.com>
Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: Soroush <sorgh@microsoft.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: zeye <2295905420@qq.com>
Co-authored-by: VanyLaw <wenyluo@microsoft.com>
Co-authored-by: Yan Liu <32497439+zxyanliu@users.noreply.github.com>
Co-authored-by: Dong Lei <donglei@microsoft.com>
Co-authored-by: LouisEugeneMSFT <66701106+LouisEugeneMSFT@users.noreply.github.com>
Co-authored-by: Louis Eugene <leugene@microsoft.com>
Co-authored-by: leilzh <leilzh@microsoft.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>
Co-authored-by: TJ Durnford <tjdford@gmail.com>
Co-authored-by: Tony Anziano <toanzian@microsoft.com>
Co-authored-by: Zhixiang Zhan <zhixzhan@microsoft.com>
Co-authored-by: liweitian <liweitian93@outlook.com>
benbrown pushed a commit that referenced this pull request Jun 11, 2021
@beyackle @hatpick
@sorgh @cwhitten @yeze322 @VanyLaw @zxyanliu @boydc2014 @LouisEugeneMSFT @lei9444 @a-b-r-o-w-n @tdurnford @tonyanziano @zhixzhan @liweitian
chore: merge latest master into multibot branch (#3518)
ede0728 
* link the application keys with bot service in provision script (#3425)

* fix: #3309 Allow configuring app settings without opening a bot project (#3454)

* issues#3309

* fixes lints

* Default to bot settings if no route cache

Co-authored-by: Soroush <sorgh@microsoft.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>

* feat: 'Ctrl + Click', 'Shift + Click' behaviors in Flow Editor (#3448)

* ctrl + click behavior

* enhance the focus behavior

* range selection e2e

* calculate accurate range selection

* MacOS Meta + Click support

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>

* fix: fix relative path of runtime folder in eject customized (#3434)

* fix runtime relative path in eject

* fix process pid not exist when runtime folder not exist

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>

* fix: typo (#3474)

* Fix a typo

Message recieved -> Message received

* Improve language

A basic brush of the Home page.

* fix: fix get history before file persistence (#3440)

* fix get history before file persistence

* flush in action not in component

* fix bug

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: Dong Lei <donglei@microsoft.com>

* fix: #2692 Tabbing / clicking / returning out of a number field round your input (#3427)

* bug fix

* pr comment

* lint

* double export

* updated test

Co-authored-by: Louis Eugene <leugene@microsoft.com>
Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>

* fix: revert plugins out of workspace (#3479)

* revert commit about add plugins into workspace

* revert other relative path change

* update the lock file

* remove yarn.lock in azure plugins to make sure bot-deploy updated

Co-authored-by: leilzh <leilzh@microsoft.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>

* chore: Hide ignored folders in vscode, update prettier config (#3493)

* issues#3309

* fixes lints

* Default to bot settings if no route cache

* fix: #3485

Co-authored-by: Soroush <sorgh@microsoft.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>

* feat: show 'AutoEndDialog' from Adaptive Dialog Property Editor (#3498)

* refactor: add rule and remove dangling underscores (#3496)

* add rule and remove dangling underscores

* update elliptic and test

Co-authored-by: Andy Brown <asbrown002@gmail.com>

* chore: added config to debug Electron main process. (#3501)

Co-authored-by: Andy Brown <asbrown002@gmail.com>

* Merge pull request #3502 from hatpick/master

fix: #3486 Debug/Fix HMR support

* fix: add logo-clicking to tests (#3500)

* add logo-clicking to tests

* bump elliptic version

* Update yarn.lock

Co-authored-by: Andy Brown <asbrown002@gmail.com>

* feat: support validate lg custom functions (#3273)

* fix: support validate lg custom functions and separate the dialog validation from parser

* use file name as namespace

* add unit test

* fix lint

* fix: inline editing LU mess up whole file (#3478)

* upgrade lu packages

* update package

* clean

* update

* clean up

Co-authored-by: Andy Brown <asbrown002@gmail.com>

* refactor: change term primary key to authoring key (#3516)

Co-authored-by: Andy Brown <asbrown002@gmail.com>

Co-authored-by: Qi Kang <kangqidev@gmail.com>
Co-authored-by: Soroush <hatpick@gmail.com>
Co-authored-by: Soroush <sorgh@microsoft.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: zeye <2295905420@qq.com>
Co-authored-by: VanyLaw <wenyluo@microsoft.com>
Co-authored-by: Yan Liu <32497439+zxyanliu@users.noreply.github.com>
Co-authored-by: Dong Lei <donglei@microsoft.com>
Co-authored-by: LouisEugeneMSFT <66701106+LouisEugeneMSFT@users.noreply.github.com>
Co-authored-by: Louis Eugene <leugene@microsoft.com>
Co-authored-by: leilzh <leilzh@microsoft.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>
Co-authored-by: TJ Durnford <tjdford@gmail.com>
Co-authored-by: Tony Anziano <toanzian@microsoft.com>
Co-authored-by: Zhixiang Zhan <zhixzhan@microsoft.com>
Co-authored-by: liweitian <liweitian93@outlook.com>
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
link the application keys with bot service in provision script (micro…
39dcbab 
…soft#3425)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

@beyackle beyackle Awaiting requested review from beyackle

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provision script should enable app insights for luis and web app
4 participants
@zidaneymar @coveralls @a-b-r-o-w-n @cwhitten