Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use api to create bot in e2e tests #3081

Merged
merged 4 commits into from
May 15, 2020
Merged

test: use api to create bot in e2e tests #3081

merged 4 commits into from
May 15, 2020

Conversation

a-b-r-o-w-n
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n commented May 15, 2020 •
edited
Loading

Description

  • Short circuit the ui to create bot for most tests (create bot spec still uses UI). This should help speed up test runs.
  • Uses baseUrl config option instead of COMPOSER_URL env var
  • Also fixes todo spec.

Task Item

refs #3081

@github-actions
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 95a6791 on abrown/test/fix-todo-spec into 7b618dd on master.

@cwhitten cwhitten merged commit 3a6466c into master May 15, 2020
@cwhitten cwhitten deleted the abrown/test/fix-todo-spec branch May 15, 2020 16:10
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request May 15, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@a-b-r-o-w-n
test: use api to create bot in e2e tests (microsoft#3081)
d120352 
* fix todo spec

* use base url config instead of env variable

* update createBot to use api instead of UI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhitten cwhitten cwhitten approved these changes

@beyackle beyackle Awaiting requested review from beyackle

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@corinagum corinagum Awaiting requested review from corinagum

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-b-r-o-w-n @cwhitten