Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Updated mac build script to target .zip artifact. #3013

Merged
merged 3 commits into from
May 12, 2020
Merged

fix: Updated mac build script to target .zip artifact. #3013

merged 3 commits into from
May 12, 2020

Conversation

tonyanziano
Copy link
Contributor

Description

electron-updater only works with .zip artifacts as the targeted asset to be downloaded.

This updates a script to generate a latest-mac.yml file that references the correct .zip instead of the .dmg target.

Task Item

Fixes #2226

@github-actions
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 540a0c8 on toanzian/update-mac into ebaec7b on master.

@tonyanziano tonyanziano merged commit 32b6774 into master May 12, 2020
@tonyanziano tonyanziano deleted the toanzian/update-mac branch May 12, 2020 23:21
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request May 15, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@tonyanziano
Changed mac build script to target .zip artifact. (microsoft#3013)
b428e26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beyackle beyackle beyackle approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonyanziano @beyackle