fix: remove github secrets from config #2991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
config inside the github sample plugin included (old) secrets
srinaath
reviewed
May 11, 2020
There was a problem hiding this comment.
Can we obliterate all historical commits to this file and create the file new in this PR to avoid showing the secret in old commits. Might not be of much value I guess if the secret and ID are no longer in use or have been changed. If thats the case then we are fine with this commit.
|
These secrets have been completely invalid for a while... I think that is sufficient, but I'm not an expert! |
|
Got it @benbrown .. I also agree with you. Should be sufficient. |
srinaath
approved these changes
May 11, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
config inside the github sample plugin included (old) secrets Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config inside the github sample plugin included (old) secrets