fix: Added missing flag to prevent concurrent downloads of the same update. #2960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwhitten
reviewed
May 8, 2020
| @@ -57,6 +57,7 @@ export class AppUpdater extends EventEmitter { | |||
|
|
|||
| public downloadUpdate() { | |||
| if (!this.downloadingUpdate) { | |||
| this.downloadingUpdate = true; | |||
There was a problem hiding this comment.
do we need to set this to false when it's finished?
There was a problem hiding this comment.
It already is being set to false in resetToIdle() which is called on error, finished downloading, or update unavailable.
cwhitten
approved these changes
May 9, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
microsoft#2960) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a line that flips a flag to prevent multiple downloads of the same update.
(Must have missed this in the original auto update PR 😮)
This check was already there, but nothing was ever flipping
downloadingUpdatetotrue.Task Item
fixes #2226