Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update some behaviors of showing error message in lu editor #2939

Merged
merged 3 commits into from
May 8, 2020
Merged

fix: update some behaviors of showing error message in lu editor #2939

merged 3 commits into from
May 8, 2020

Conversation

lei9444
Copy link
Contributor

@lei9444 lei9444 commented May 7, 2020 •
edited
Loading

Description

  1. In create a new intent trigger, when intent name is updating, we should update the diagnostic.
  2. use diagnostics from parsed files to update the all up view error message.

Task Item

refs #2938
refs #2904

Screenshots

test

@lei9444 lei9444 requested a review from zhixzhan May 7, 2020 09:42
@lei9444 lei9444 changed the title fix: update the behavior of showing error message in lu editor fix: update some behaviors of showing error message in lu editor May 7, 2020
@a-b-r-o-w-n a-b-r-o-w-n added the Approved to merge approved, waiting to be merged label May 7, 2020
@coveralls
Copy link

coveralls commented May 7, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 0.0% when pulling 53ef0f0 on lei9444:luError into cc66deb on microsoft:master.

@cwhitten cwhitten merged commit aa372a4 into microsoft:master May 8, 2020
@lei9444 lei9444 deleted the luError branch May 9, 2020 00:37
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request May 15, 2020
Merged
lei9444 added a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@lei9444 @a-b-r-o-w-n @cwhitten
fix: editor show error (microsoft#2939)
f8087d9 
Co-authored-by: Andy Brown <asbrown002@gmail.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

@zhixzhan zhixzhan Awaiting requested review from zhixzhan

@beyackle beyackle Awaiting requested review from beyackle

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
Approved to merge approved, waiting to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lei9444 @coveralls @a-b-r-o-w-n @cwhitten