fix: add a new help URL to the Expression editor #2814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwhitten
previously approved these changes
Apr 28, 2020
a-b-r-o-w-n
requested changes
Apr 28, 2020
Composer/packages/extensions/adaptive-form/src/components/FormRow.tsx
Outdated
Show resolved
Hide resolved
…t/BotFramework-Composer into beyackle/multilineError
…t/BotFramework-Composer into beyackle/multilineError
|
I have no idea why fixing conflicts causes it to replay all of the commits back in this weird snowballing fashion. |
a-b-r-o-w-n
requested changes
Apr 30, 2020
Composer/packages/extensions/adaptive-form/src/utils/getUIOptions.ts
Outdated
Show resolved
Hide resolved
a-b-r-o-w-n
approved these changes
Apr 30, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* fix: make error messages multiline * pass customizable help URL through as prop * move HELP_URL * fix location to somewhere more sensible * Update package.json * Update package.json * pass customizable help URL through as prop * move HELP_URL * fix location to somewhere more sensible * Update package.json * Update package.json * suggestions from PR * pass customizable help URL through as prop * move HELP_URL * fix location to somewhere more sensible * Update package.json * Update package.json * suggestions from PR * pass customizable help URL through as prop * move HELP_URL * fix location to somewhere more sensible * Update package.json * fix stray props * make helpLink name consistent * Update SkillEndpointField.tsx * apply fixes from comments * pass customizable help URL through as prop * move HELP_URL * fix location to somewhere more sensible * Update package.json * Update package.json * suggestions from PR * pass customizable help URL through as prop * move HELP_URL * fix location to somewhere more sensible * Update package.json * pass customizable help URL through as prop * move HELP_URL * fix location to somewhere more sensible * suggestions from PR * pass customizable help URL through as prop * move HELP_URL * fix location to somewhere more sensible * Update package.json * fix stray props * make helpLink name consistent * Update SkillEndpointField.tsx * apply fixes from comments * Update SchemaField.tsx * Update PropertyEditor.tsx * make suggested changes and fix unit test Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds in a help URL to the expression editor, plus some plumbing to make it easy to decorate other sorts of fields with whatever other syntax help URLs we need.
Task Item
closes #2792
Screenshots