fix: Remove the duplicate types for schema #2782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luhan2017
approved these changes
Apr 27, 2020
luhan2017
added a commit
that referenced
this pull request
Apr 28, 2020
* Update sdk schema * use dialog:merge to generate the schema * Update readme.md * Update * remove R9 * render select field for all enums, not just strings * merge parent schema into resolved schema for oneOf * enable dropdown option in OneOfField * handle new expression schema shapestill more to do * remove value field in prompts * show card action in choices form * allow oneOf schema to set placeholder * account for rows when checking to stack items * clean up choices form schema * remove json plugin http request body is an expression now, so the expression plugin handles it * render choice action as json editor still need to pass in schema * pass schema through json field * do not merge parent schema into oneOf * update lockfile * remove emit event plugin * if type is undefined, use string field * get enum options from oneOf schemas * enable fetching of schema * add recognizer options to prompt fields * fix issue passing errors in array items * stop-gap for blocking shell operation * update schema * fix jest config * allow for setting startup command for e2e * fix notification page spec expression is now the default option * Schema update * Update sdk.schema * remove the duplicate types for schema (#2782) Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: leileizhang <leilzh@microsoft.com>
lei9444
added a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* Update sdk schema * use dialog:merge to generate the schema * Update readme.md * Update * remove R9 * render select field for all enums, not just strings * merge parent schema into resolved schema for oneOf * enable dropdown option in OneOfField * handle new expression schema shapestill more to do * remove value field in prompts * show card action in choices form * allow oneOf schema to set placeholder * account for rows when checking to stack items * clean up choices form schema * remove json plugin http request body is an expression now, so the expression plugin handles it * render choice action as json editor still need to pass in schema * pass schema through json field * do not merge parent schema into oneOf * update lockfile * remove emit event plugin * if type is undefined, use string field * get enum options from oneOf schemas * enable fetching of schema * add recognizer options to prompt fields * fix issue passing errors in array items * stop-gap for blocking shell operation * update schema * fix jest config * allow for setting startup command for e2e * fix notification page spec expression is now the default option * Schema update * Update sdk.schema * remove the duplicate types for schema (microsoft#2782) Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: leileizhang <leilzh@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ignore the same type
Task Item
refs #2729
Screenshots