Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Updated some auto-update UX copy to be more accurate. #2744

Merged
merged 2 commits into from
Apr 22, 2020
Merged

fix: Updated some auto-update UX copy to be more accurate. #2744

merged 2 commits into from
Apr 22, 2020

Conversation

tonyanziano
Copy link
Contributor

@tonyanziano tonyanziano commented Apr 22, 2020 •
edited by a-b-r-o-w-n
Loading

Description

Updated some copy in the auto-update UX to more accurately represent what is actually happening under the hood.

Task Item

refs #2226

Screenshots

Update available (Before)

copy-before

Update available (After)

copy-after

Update succeeded (Before)

copy2-before

Update succeeded (After)

copy2-after

a-b-r-o-w-n
a-b-r-o-w-n requested changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a failing unit test!

@github-actions
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 3208fb0 on toanzian/update-copy into 227c2a0 on master.

@tonyanziano tonyanziano merged commit 435952b into master Apr 22, 2020
@tonyanziano tonyanziano deleted the toanzian/update-copy branch April 22, 2020 20:12
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request May 15, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@tonyanziano
fix: Updated some auto-update UX copy to be more accurate. (microsoft…
a501e9e 
…#2744)

* Updated some auto-update UX copy to be more accurate.

* Fixed failing test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonyanziano @a-b-r-o-w-n