Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y: accessibility issue on create new bot dialog #2683

Merged
merged 3 commits into from
Apr 17, 2020

Conversation

liweitian
Copy link
Contributor

@liweitian liweitian commented Apr 16, 2020

Description

The issue is:
Click the New button on the home page to open the create a new bot dialog
when we choose the option between 'create from template' or 'create from scratch', the screen reader does not announce anything.
And I am sorry I cannot find the related task id (There is one!). So I create one by myself.

Task Item

Refs #2684

Screenshots

@liweitian liweitian changed the title fix accessibility issue on create new bot dialog a11y: accessibility issue on create new bot dialog Apr 16, 2020
@github-actions
Copy link

Coverage Status

Coverage decreased (-0.01%) to 40.93% when pulling e4a6136 on liweitian:accessibilityCreateOptions into 723785b on microsoft:master.

Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks for the catch

@corinagum corinagum merged commit 60aa477 into microsoft:master Apr 17, 2020
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
Co-authored-by: Corina <14900841+corinagum@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants