Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show bot url as tooltip #2676

Merged
merged 15 commits into from
Apr 21, 2020
Merged

fix: show bot url as tooltip #2676

merged 15 commits into from
Apr 21, 2020

Conversation

boydc2014
Copy link
Contributor

@boydc2014 boydc2014 commented Apr 16, 2020 •
edited
Loading

image

fixes #2530

@boydc2014 boydc2014 changed the base branch from stable to master April 16, 2020 09:35
@a-b-r-o-w-n a-b-r-o-w-n self-assigned this Apr 16, 2020
a-b-r-o-w-n
a-b-r-o-w-n reviewed Apr 16, 2020
View reviewed changes
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the failing unit test, this looks good.

@cwhitten
Copy link
Member

Dong can you provide an icon that when clicked just copies the connection string to the clipboard?

@cwhitten
Copy link
Member

see this codepen https://codepen.io/cwhitten/pen/abvNwKR

@github-actions
Copy link

Coverage Status

Coverage decreased (-1.009%) to 40.94% when pulling f5432b8 on donglei/show-botendpoint into 9bf98c7 on master.

@boydc2014
Copy link
Contributor Author

Thanks @cwhitten and @a-b-r-o-w-n, here is the updated version

image

@boydc2014 boydc2014 requested a review from cwhitten April 21, 2020 00:42
@cwhitten cwhitten merged commit 8f3e17c into master Apr 21, 2020
@cwhitten cwhitten deleted the donglei/show-botendpoint branch April 21, 2020 04:07
@cwhitten cwhitten mentioned this pull request Apr 21, 2020
Closed
7 tasks
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request May 15, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@boydc2014 @cwhitten @a-b-r-o-w-n
fix: show bot url as tooltip (microsoft#2676)
dd7f39f 
* show botendpoint as tooltip

* fix lint

* Fix tests

* add a button to write to clipboard

* fix lint

* remove close delay and URL prefix

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n left review comments

@cwhitten cwhitten cwhitten approved these changes

@benbrown benbrown Awaiting requested review from benbrown

@corinagum corinagum Awaiting requested review from corinagum

@luhan2017 luhan2017 Awaiting requested review from luhan2017

@yeze322 yeze322 Awaiting requested review from yeze322

Assignees

@a-b-r-o-w-n a-b-r-o-w-n

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose bot port in Composer
3 participants
@boydc2014 @cwhitten @a-b-r-o-w-n