Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a11y: Add role project tree #2637

Merged
merged 8 commits into from
Apr 15, 2020
Merged

a11y: Add role project tree #2637

merged 8 commits into from
Apr 15, 2020

Conversation

lei9444
Copy link
Contributor

@lei9444 lei9444 commented Apr 14, 2020 •
edited
Loading

Description

image

Task Item

refs #2016

Screenshots

corinagum
corinagum suggested changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2016 looks good!
#2054 behavior is not fixed yet.

Previously, the narrator would say 'Filter dialog. Search box. Filter dialog'
Now, the narrator says 'Search box. Search box. Filter dialog'

@lei9444
Copy link
Contributor Author

lei9444 commented Apr 15, 2020 •
edited
Loading

#2016 looks good!
#2054 behavior is not fixed yet.

Previously, the narrator would say 'Filter dialog. Search box. Filter dialog'
Now, the narrator says 'Search box. Search box. Filter dialog'

Hi @corinagum I have removed the aria-label in searchbox, so this PR only fix #2016 now. I will create a new PR #2653 to fix #2054

@lei9444 lei9444 changed the title a11y: Add role and label to filter dialog and project tree a11y: Add role project tree Apr 15, 2020
@corinagum corinagum merged commit b67799a into microsoft:master Apr 15, 2020
@corinagum corinagum mentioned this pull request Apr 15, 2020
Merged
@lei9444 lei9444 deleted the fixa11y branch May 9, 2020 00:38
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request May 15, 2020
Merged
lei9444 added a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@lei9444 @corinagum
a11y: Add role project tree (microsoft#2637)
9ec670b 
* a11y: Add role and label to filter dialog and project tree

* update the label name

* remove the label

Co-authored-by: Corina <14900841+corinagum@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

Assignees

@corinagum corinagum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lei9444 @corinagum